Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751436AbdGQRu3 (ORCPT ); Mon, 17 Jul 2017 13:50:29 -0400 Received: from o1.7nn.fshared.sendgrid.net ([167.89.55.65]:16738 "EHLO o1.7nn.fshared.sendgrid.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751293AbdGQRu1 (ORCPT ); Mon, 17 Jul 2017 13:50:27 -0400 Date: Mon, 17 Jul 2017 17:50:27 +0000 (UTC) From: Craig Inches To: "Dilger, Andreas" Cc: "Drokin, Oleg" , James Simmons , Greg Kroah-Hartman , "lustre-devel@lists.lustre.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 4/4] Staging: Lustre Fix block statement style issue Message-ID: <20170717175017.GA32268@battlestar> Mail-Followup-To: "Dilger, Andreas" , "Drokin, Oleg" , James Simmons , Greg Kroah-Hartman , "lustre-devel@lists.lustre.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" References: <774a2f25b839305f100e7fa99ebf835fb2ab7d44.1499849566.git.Craig@craiginches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) X-SG-EID: UsLXQ589HNP4HLBydmD9pgHURQozLYm9XliudupI8YsZSvJe2siduQuUUpkktUQFC4Pj3qCORHSISX rzlEG69V5b6/R3e63wa9/oVWfkleys0p47I1pDh3OJ1Nbn5WvXf2ImkDynwxjRG/PaeAKgifjqWPeA +OcAR88ED7YEdvPncG6iftJR+MxjguQqlrAhz3kobNYj0m0JE2EKGBfXAcLBAKnadvYWbmK941l+br E= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1461 Lines: 37 On Mon, Jul 17, 2017 at 05:44:59PM +0000, Dilger, Andreas wrote: > On Jul 12, 2017, at 03:03, Craig Inches wrote: > > > > This fixes a block statement which didnt end with */ > > > > Signed-off-by: Craig Inches > > --- > > drivers/staging/lustre/include/linux/lnet/socklnd.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/lustre/include/linux/lnet/socklnd.h b/drivers/staging/lustre/include/linux/lnet/socklnd.h > > index dd5bc0e46560..a1ae66ede7a8 100644 > > --- a/drivers/staging/lustre/include/linux/lnet/socklnd.h > > +++ b/drivers/staging/lustre/include/linux/lnet/socklnd.h > > @@ -76,7 +76,8 @@ struct ksock_msg { > > __u64 ksm_zc_cookies[2]; /* Zero-Copy request/ACK cookie */ > > union { > > struct ksock_lnet_msg lnetmsg; /* lnet message, it's empty if > > - * it's NOOP */ > > + * it's NOOP > > + */ > > Rather than making the multi-line comments even more space consuming (I'm not a big > fan of "*/ must be on a line by itself" since it wastes a lot of vertical space), > I'd prefer to just shorten the comment, if possible, like: > > struct ksock_lnet_msg lnetmsg; /* lnet message, empty if NOOP */ That makes sense, I believe the series has already made it to staging-next, so not sure what the process would be to fix it up. I am doing another set of style fixes which I can include this change aswell. Cheers, Craig