Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751412AbdGQSzU (ORCPT ); Mon, 17 Jul 2017 14:55:20 -0400 Received: from mga06.intel.com ([134.134.136.31]:55073 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751311AbdGQSzS (ORCPT ); Mon, 17 Jul 2017 14:55:18 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,375,1496127600"; d="scan'208";a="127756168" From: "Pandiyan, Dhinakaran" To: "mka@chromium.org" CC: "linux-kernel@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "grundler@chromium.org" , "Taylor, Clinton A" , "Vetter, Daniel" , "daniel@ffwll.ch" , "dri-devel@lists.freedesktop.org" , "airlied@linux.ie" , "stephane.marchesin@gmail.com" , "Vivi, Rodrigo" , "jani.nikula@linux.intel.com" Subject: Re: [Intel-gfx] [PATCH] drm/i915: Return correct EDP voltage swing table for 0.85V Thread-Topic: [Intel-gfx] [PATCH] drm/i915: Return correct EDP voltage swing table for 0.85V Thread-Index: AQHS/y4715j5zKp47EiCZJ6uG+/5zw== Date: Mon, 17 Jul 2017 18:55:17 +0000 Message-ID: <1500318919.18069.5.camel@dk-H97M-D3H> References: <20170717182127.59072-1-mka@chromium.org> In-Reply-To: <20170717182127.59072-1-mka@chromium.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.54.75.5] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v6HItQnU032618 Content-Length: 1465 Lines: 39 Looks like a typo in cf54ca8 ("drm/i915/cnl: Implement voltage swing sequence.") but Cc'ing Rodrigo, Clint to make sure this wasn't a workaround. -DK On Mon, 2017-07-17 at 11:21 -0700, Matthias Kaehlcke wrote: > For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP. > Use the correct table. > > The error was pointed out by this clang warning: > > drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable > 'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted > [-Wunneeded-internal-declaration] > static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = { > > Signed-off-by: Matthias Kaehlcke > --- > drivers/gpu/drm/i915/intel_ddi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c > index efb13582dc73..6fa02e6a7a9b 100644 > --- a/drivers/gpu/drm/i915/intel_ddi.c > +++ b/drivers/gpu/drm/i915/intel_ddi.c > @@ -1873,7 +1873,7 @@ cnl_get_buf_trans_edp(struct drm_i915_private *dev_priv, > if (dev_priv->vbt.edp.low_vswing) { > if (voltage == VOLTAGE_INFO_0_85V) { > *n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_85V); > - return cnl_ddi_translations_dp_0_85V; > + return cnl_ddi_translations_edp_0_85V; > } else if (voltage == VOLTAGE_INFO_0_95V) { > *n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_95V); > return cnl_ddi_translations_edp_0_95V;