Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751415AbdGQTFr (ORCPT ); Mon, 17 Jul 2017 15:05:47 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:33220 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751311AbdGQTFp (ORCPT ); Mon, 17 Jul 2017 15:05:45 -0400 MIME-Version: 1.0 In-Reply-To: References: <1499972649-6200-1-git-send-email-abhishek.shah@broadcom.com> <1499972649-6200-3-git-send-email-abhishek.shah@broadcom.com> From: Jon Mason Date: Mon, 17 Jul 2017 15:05:44 -0400 Message-ID: Subject: Re: [PATCH 2/3] net: ethernet: bgmac: Make IDM register space optional To: Abhishek Shah Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Florian Fainelli , "David S . Miller" , Rob Herring , Mark Rutland , Network Development , open list , linux-arm-kernel , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , BCM Kernel Feedback Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 948 Lines: 27 On Mon, Jul 17, 2017 at 2:37 PM, Abhishek Shah wrote: > Hi Jon, > >> This also will need to be added to >> drivers/net/ethernet/broadcom/bgmac-bcma.c. Otherwise, the driver >> will no longer work for those platforms. Since this was already >> accepted, please push out a fix ASAP. >> > I do not see how the bcma driver [bgmac-bcma.c] will no longer work. > The whole idea behind introducing this BGMAC_FEAT_IDM_MASK bit > was to keep bcma driver's functionality intact. > > The BGMAC_FEAT_IDM_MASK bit is explicitly set by the bgmac-platform driver > and is unset inside the same if the idm register base is provided. > > For BCMA driver case, I do not touch BGMAC_FEAT_IDM_MASK bit, i.e. it > is *not* set. > And if it is not set, each idm operation done in bgmac.c will take place. > Please explain if I am missing something here. Sorry, I had it flipped in my mind. Please disregard. > > > Regards, > Abhishek