Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751402AbdGQTff (ORCPT ); Mon, 17 Jul 2017 15:35:35 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:43832 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbdGQTfd (ORCPT ); Mon, 17 Jul 2017 15:35:33 -0400 From: Vivien Didelot To: Andrew Lunn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops In-Reply-To: <20170717192734.GD9363@lunn.ch> References: <20170717170346.19555-1-vivien.didelot@savoirfairelinux.com> <20170717170346.19555-12-vivien.didelot@savoirfairelinux.com> <20170717192734.GD9363@lunn.ch> Date: Mon, 17 Jul 2017 15:32:52 -0400 Message-ID: <87bmoiuae3.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 566 Lines: 18 Hi Andrew, Andrew Lunn writes: > I never liked this. I think it is architecturally wrong for the switch > to be poking around in the PHY. It should ask the PHY driver. This is > especially true for external PHYs which might not be a Marvell PHY. I share the same concern. However this patch is just isolating the existing code so that we get rid of the last caps and flags and stop writing (without reading them first) arbitrary registers. Once this portion is moved to the PHY driver, one can remove it from mv88e6xxx. Thanks, Vivien