Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751394AbdGQUiN (ORCPT ); Mon, 17 Jul 2017 16:38:13 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:57780 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbdGQUiM (ORCPT ); Mon, 17 Jul 2017 16:38:12 -0400 Date: Mon, 17 Jul 2017 13:38:09 -0700 (PDT) Message-Id: <20170717.133809.1388368429079194648.davem@davemloft.net> To: arvind.yadav.cs@gmail.com Cc: nicolas.ferre@microchip.com, kvalo@codeaurora.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/11] net: cadence: macb: constify pci_device_id. From: David Miller In-Reply-To: <1500315112-3249-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1500315112-3249-1-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 17 Jul 2017 13:38:11 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 664 Lines: 18 From: Arvind Yadav Date: Mon, 17 Jul 2017 23:41:52 +0530 > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by work with > const pci_device_id. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 791 336 0 1127 467 net/ethernet/cadence/macb_pci.o > > File size After adding 'const': > text data bss dec hex filename > 855 272 0 1127 467 net/ethernet/cadence/macb_pci.o > > Signed-off-by: Arvind Yadav Applied.