Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751430AbdGQUpv (ORCPT ); Mon, 17 Jul 2017 16:45:51 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:58136 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbdGQUpu (ORCPT ); Mon, 17 Jul 2017 16:45:50 -0400 Date: Mon, 17 Jul 2017 13:45:49 -0700 (PDT) Message-Id: <20170717.134549.2101398770863549187.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: andrew@lunn.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, f.fainelli@gmail.com Subject: Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops From: David Miller In-Reply-To: <87bmoiuae3.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> References: <20170717170346.19555-12-vivien.didelot@savoirfairelinux.com> <20170717192734.GD9363@lunn.ch> <87bmoiuae3.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 17 Jul 2017 13:45:49 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 723 Lines: 21 From: Vivien Didelot Date: Mon, 17 Jul 2017 15:32:52 -0400 > Hi Andrew, > > Andrew Lunn writes: > >> I never liked this. I think it is architecturally wrong for the switch >> to be poking around in the PHY. It should ask the PHY driver. This is >> especially true for external PHYs which might not be a Marvell PHY. > > I share the same concern. However this patch is just isolating the > existing code so that we get rid of the last caps and flags and stop > writing (without reading them first) arbitrary registers. > > Once this portion is moved to the PHY driver, one can remove it from > mv88e6xxx. Seems a reasonable plan of action. Andrew, do you agree?