Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751474AbdGQVK0 (ORCPT ); Mon, 17 Jul 2017 17:10:26 -0400 Received: from mga03.intel.com ([134.134.136.65]:65436 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335AbdGQVKZ (ORCPT ); Mon, 17 Jul 2017 17:10:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,375,1496127600"; d="scan'208";a="994030675" Date: Mon, 17 Jul 2017 14:17:13 -0700 From: Manasi Navare To: "Pandiyan, Dhinakaran" Cc: "mka@chromium.org" , "grundler@chromium.org" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "Vivi, Rodrigo" , "Vetter, Daniel" Subject: Re: [Intel-gfx] [PATCH] drm/i915: Return correct EDP voltage swing table for 0.85V Message-ID: <20170717211713.GA6173@intel.com> References: <20170717182127.59072-1-mka@chromium.org> <1500318919.18069.5.camel@dk-H97M-D3H> <1500326360.18069.12.camel@dk-H97M-D3H> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1500326360.18069.12.camel@dk-H97M-D3H> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2492 Lines: 65 On Mon, Jul 17, 2017 at 08:59:18PM +0000, Pandiyan, Dhinakaran wrote: > > > > On Mon, 2017-07-17 at 18:55 +0000, Pandiyan, Dhinakaran wrote: > > Looks like a typo in > > > > cf54ca8 ("drm/i915/cnl: Implement voltage swing sequence.") > > > > but Cc'ing Rodrigo, Clint to make sure this wasn't a workaround. > > > > -DK > > Checked with Clint, this wasn't a workaround, a typo indeed. > > Yup, Like I mentioned in the previous reply, I am positive that this should return cnl_ddi_translations_edp_0_85 since I had discussed this with Rodrigo while working on ddi buffer initialization. Matthias, please go ahead and add the Fixes Tag like I mentioned in my previous message. Thanks for catching this. Manasi > > > On Mon, 2017-07-17 at 11:21 -0700, Matthias Kaehlcke wrote: > > > For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP. > > > Use the correct table. > > > > > > The error was pointed out by this clang warning: > > > > > > drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable > > > 'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted > > > [-Wunneeded-internal-declaration] > > > static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = { > > > > > > Signed-off-by: Matthias Kaehlcke > > > --- > > > drivers/gpu/drm/i915/intel_ddi.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c > > > index efb13582dc73..6fa02e6a7a9b 100644 > > > --- a/drivers/gpu/drm/i915/intel_ddi.c > > > +++ b/drivers/gpu/drm/i915/intel_ddi.c > > > @@ -1873,7 +1873,7 @@ cnl_get_buf_trans_edp(struct drm_i915_private *dev_priv, > > > if (dev_priv->vbt.edp.low_vswing) { > > > if (voltage == VOLTAGE_INFO_0_85V) { > > > *n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_85V); > > > - return cnl_ddi_translations_dp_0_85V; > > > + return cnl_ddi_translations_edp_0_85V; > > > } else if (voltage == VOLTAGE_INFO_0_95V) { > > > *n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_95V); > > > return cnl_ddi_translations_edp_0_95V; > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel