Date: Mon, 17 Jul 2017 14:10:48 -0700 (PDT)
Message-Id: <20170717.141048.999243831453421230.davem@davemloft.net>
To: andrew@lunn.ch
Cc: vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,
        f.fainelli@gmail.com
Subject: Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect
 ops
From: David Miller <davem@davemloft.net>
In-Reply-To: <20170717210405.GC11719@lunn.ch>
References: <87bmoiuae3.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
        <20170717.134549.2101398770863549187.davem@davemloft.net>
        <20170717210405.GC11719@lunn.ch>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1207
Lines: 36

From: Andrew Lunn <andrew@lunn.ch>
Date: Mon, 17 Jul 2017 23:04:05 +0200

> On Mon, Jul 17, 2017 at 01:45:49PM -0700, David Miller wrote:
>> From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>> Date: Mon, 17 Jul 2017 15:32:52 -0400
>> 
>> > Hi Andrew,
>> > 
>> > Andrew Lunn <andrew@lunn.ch> writes:
>> > 
>> >> I never liked this. I think it is architecturally wrong for the switch
>> >> to be poking around in the PHY. It should ask the PHY driver. This is
>> >> especially true for external PHYs which might not be a Marvell PHY.
>> > 
>> > I share the same concern. However this patch is just isolating the
>> > existing code so that we get rid of the last caps and flags and stop
>> > writing (without reading them first) arbitrary registers.
>> > 
>> > Once this portion is moved to the PHY driver, one can remove it from
>> > mv88e6xxx.
>> 
>> Seems a reasonable plan of action.
>> 
>> Andrew, do you agree?
> 
> Hi David
> 
> I just fear it will not get fixed, just put into a corner to
> fester. Having to fix it properly before these patches are merged
> provides some incentive.

If Vivien doesn't make good on his promises to do so, tell me and
I will revert all of these changes.

Ok?