From: "Kershner, David A" <David.Kershner@unisys.com>
To: Greg KH <greg@kroah.com>, Arvind Yadav <arvind.yadav.cs@gmail.com>
CC: "Sell, Timothy C" <Timothy.Sell@unisys.com>,
        "Thompson, Bryan E." <bryan.thompson@unisys.com>,
        "jon.frisch@unisys.com" <jon.frisch@unisys.com>,
        "Binder, David Anthony" <David.Binder@unisys.com>,
        *S-Par-Maintainer <SParMaintainer@unisys.com>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] staging: unisys: visorbus: constify attribute_group
 structures.
Thread-Topic: [PATCH] staging: unisys: visorbus: constify attribute_group
 structures.
Thread-Index: AQHS/unPEuRNZ97hvEeaFYEQ7kKSjaJX9Sd7gACWaHA=
Date: Mon, 17 Jul 2017 21:36:58 +0000
Message-ID: <CY4PR07MB31764083B4606C00677853A5F0A00@CY4PR07MB3176.namprd07.prod.outlook.com>
References: <f19a33269ee221f31afdfd18be88f5275b6082be.1500283291.git.arvind.yadav.cs@gmail.com>
 <20170717104522.GA32372@kroah.com>
 <f5e3becd-8702-5d00-171c-8b6bdcc17f50@gmail.com>
 <20170717123734.GA30411@kroah.com>
In-Reply-To: <20170717123734.GA30411@kroah.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2017 21:36:59.0435
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8d894c2b-238f-490b-8dd1-d93898c5bf83
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3126
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v6HLb8Xw008255
Content-Length: 2376
Lines: 60

> -----Original Message-----
> From: Greg KH [mailto:greg@kroah.com]
> Sent: Monday, July 17, 2017 8:38 AM
> To: Arvind Yadav <arvind.yadav.cs@gmail.com>
> Cc: Kershner, David A <David.Kershner@unisys.com>; Sell, Timothy C
> <Timothy.Sell@unisys.com>; Thompson, Bryan E.
> <bryan.thompson@unisys.com>; jon.frisch@unisys.com; Binder, David
> Anthony <David.Binder@unisys.com>; *S-Par-Maintainer
> <SParMaintainer@unisys.com>; devel@driverdev.osuosl.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] staging: unisys: visorbus: constify attribute_group
> structures.
> 
> On Mon, Jul 17, 2017 at 05:43:14PM +0530, Arvind Yadav wrote:
> > Hi Greg,
> >
> >
> > On Monday 17 July 2017 04:15 PM, Greg KH wrote:
> > > On Mon, Jul 17, 2017 at 02:55:37PM +0530, Arvind Yadav wrote:
> > > > attribute_groups are not supposed to change at runtime. All functions
> > > > working with attribute_groups provided by <linux/sysfs.h> work
> > > > with const attribute_group. So mark the non-const structs as const.
> > > >
> > > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> > > > ---
> > > >   drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
> > > >   drivers/staging/unisys/visorbus/visorchipset.c  | 2 +-
> > > >   2 files changed, 3 insertions(+), 3 deletions(-)
> > > Why not just use the ATTRIBUTE_GROUPS() macro for these?  Or is there
> > > something that is preventing that?
> > Yes, we can use. if we are only initializing '.attrs'.
> > ATTRIBUTE_GROUPS() will not work if we will initialize other member of
> > attribute_group like 'bin_attrs', 'is_visible', and  'name'.
> 
> That means you should redo this patch :)
> 
> Also, your changelog text had a typo, it is "attribute_group", not
> "attribute_groups".
> 

Greg, are you recommending that we shouldn't be setting the attribute_group
.name field? What does it pick up if we don't specify it?

Also, for our attribute_groups in visorchipset, we are defining it with two
different attribute_group variables. Are you allowed to use two different
attribute_group variables in an attribute_groups, or is this frowned upon and
we should flatten it out to just one? An example that we used in the kernel was:

	static const struct attribute_group *l2_cache_pmu_attr_grps[] = {
		&l2_cache_pmu_format_group,
		&l2_cache_pmu_cpumask_group,
		NULL,
	};

Thanks,
David Kershner

> thanks,
> 
> greg k-h