Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751610AbdGRAAV (ORCPT ); Mon, 17 Jul 2017 20:00:21 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:46976 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751351AbdGRAAU (ORCPT ); Mon, 17 Jul 2017 20:00:20 -0400 Date: Mon, 17 Jul 2017 17:00:18 -0700 From: Matthew Wilcox To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mhocko@suse.com, ak@linux.intel.com, mtk.manpages@gmail.com, Davidlohr Bueso , khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, aarcange@redhat.com Subject: Re: [RFC PATCH 1/3] mm:hugetlb: Define system call hugetlb size encodings in single file Message-ID: <20170718000018.GD14983@bombadil.infradead.org> References: <20170328175408.GD7838@bombadil.infradead.org> <1500330481-28476-1-git-send-email-mike.kravetz@oracle.com> <1500330481-28476-2-git-send-email-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1500330481-28476-2-git-send-email-mike.kravetz@oracle.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 506 Lines: 10 On Mon, Jul 17, 2017 at 03:27:59PM -0700, Mike Kravetz wrote: > +#define HUGETLB_FLAG_ENCODE_512KB (19 << MAP_HUGE_SHIFT > +#define HUGETLB_FLAG_ENCODE_1MB (20 << MAP_HUGE_SHIFT) > +#define HUGETLB_FLAG_ENCODE_2MB (21 << MAP_HUGE_SHIFT) > +#define HUGETLB_FLAG_ENCODE_8MB (23 << MAP_HUGE_SHIFT) > +#define HUGETLB_FLAG_ENCODE_16MB (24 << MAP_HUGE_SHIFT) > +#define HUGETLB_FLAG_ENCODE_1GB (30 << MAP_HUGE_SHIFT) > +#define HUGETLB_FLAG_ENCODE__16GB (34 << MAP_HUGE_SHIFT) The __ seems like a mistake?