Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751366AbdGRFNl (ORCPT ); Tue, 18 Jul 2017 01:13:41 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:26783 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750730AbdGRFNk (ORCPT ); Tue, 18 Jul 2017 01:13:40 -0400 Message-ID: <1500354813.19736.7.camel@mtkswgap22> Subject: Re: [PATCH net-next v2 1/4] dt-bindings: net: mediatek: add support for MediaTek MT7623 and MT7622 SoC From: Sean Wang To: Andrew Lunn CC: , , , , , Date: Tue, 18 Jul 2017 13:13:33 +0800 In-Reply-To: <20170717133811.GA30392@lunn.ch> References: <20170717133811.GA30392@lunn.ch> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1733 Lines: 48 On Mon, 2017-07-17 at 15:38 +0200, Andrew Lunn wrote: > On Mon, Jul 17, 2017 at 06:06:22PM +0800, sean.wang@mediatek.com wrote: > > From: Sean Wang > > > > The patch adds the supplements in the dt-binding document for MediaTek > > MT7622 SoC with extra SGMII system controller and relevant clock consumers > > listed as the requirements for those SoCs equipped with the SGMII circuit. > > Also, add the missing binding information for MT7623 SoC here which relies > > on the fallback binding of MT2701. > > > > Signed-off-by: Sean Wang > > --- > > Documentation/devicetree/bindings/net/mediatek-net.txt | 12 +++++++++--- > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt > > index c7194e8..1d1168b 100644 > > --- a/Documentation/devicetree/bindings/net/mediatek-net.txt > > +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt > > @@ -7,24 +7,30 @@ have dual GMAC each represented by a child node.. > > * Ethernet controller node > > > > Required properties: > > -- compatible: Should be "mediatek,mt2701-eth" > > +- compatible: Should be > > + "mediatek,mt2701-eth": for MT2701 SoC > > + "mediatek,mt7623-eth", "mediatek,mt2701-eth": for MT7623 SoC > > Hi Sean > > We appear to have "mediatek,mt2701-eth" twice. > Hi, Andrew mt7623-eth supported up to now currently rely on the fallback binding of mt2701-eth in fact, the logic could be commonly found in many driver such as mtk sysirq such as [1] did, so i felt this usage should not make something wrong. [1] https://patchwork.kernel.org/patch/9739827/ > Andrew