Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751355AbdGRF5Z convert rfc822-to-8bit (ORCPT ); Tue, 18 Jul 2017 01:57:25 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:34366 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbdGRF5X (ORCPT ); Tue, 18 Jul 2017 01:57:23 -0400 Date: Tue, 18 Jul 2017 06:57:15 +0100 User-Agent: K-9 Mail for Android In-Reply-To: <20170718053808.13036-1-gehariprasath@gmail.com> References: <20170718053808.13036-1-gehariprasath@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [PATCH] staging: iio: adc: add space around substraction operation To: Hari Prasath , lars@metafoo.de CC: gehariprasath@gmail.com, Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Jonathan Cameron Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1471 Lines: 47 On 18 July 2017 06:38:08 BST, Hari Prasath wrote: >Fix checkpatch warning to add space around the substraction operation > >Signed-off-by: Hari Prasath >--- > drivers/staging/iio/adc/ad7280a.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/staging/iio/adc/ad7280a.c >b/drivers/staging/iio/adc/ad7280a.c >index d5ab83f..d79e774 100644 >--- a/drivers/staging/iio/adc/ad7280a.c >+++ b/drivers/staging/iio/adc/ad7280a.c >@@ -745,14 +745,14 @@ static irqreturn_t ad7280_event_handler(int irq, >void *private) > } > > static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value, >- in_voltage-voltage_thresh_low_value, >+ in_voltage - voltage_thresh_low_value, > 0644, > ad7280_read_channel_config, > ad7280_write_channel_config, > AD7280A_CELL_UNDERVOLTAGE); > > static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value, >- in_voltage-voltage_thresh_high_value, >+ in_voltage - voltage_thresh_high_value, > 0644, > ad7280_read_channel_config, > ad7280_write_channel_config, Check what this code actually does. Using checkpatch gives suggestions of where to look for issues; it is not always right! This change breaks the userspace ABI. Jonathan Ps when ever I see a patch involving whitespace and this driver I know I am going to give roughly this response having done so perhaps 10 times in the past! -- Sent from my Android device with K-9 Mail. Please excuse my brevity.