Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751366AbdGRGvB (ORCPT ); Tue, 18 Jul 2017 02:51:01 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35594 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbdGRGvA (ORCPT ); Tue, 18 Jul 2017 02:51:00 -0400 Date: Tue, 18 Jul 2017 08:50:35 +0200 From: Greg KH To: Arvind Yadav Cc: david.kershner@unisys.com, Timothy.Sell@unisys.com, bryan.thompson@unisys.com, jon.frisch@unisys.com, david.binder@unisys.com, sparmaintainer@unisys.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: unisys: visorbus: Constify attribute_group structures. Message-ID: <20170718065034.GA29567@kroah.com> References: <5640372c21153b23cf335197af02feb86cce30ac.1500355038.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5640372c21153b23cf335197af02feb86cce30ac.1500355038.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 716 Lines: 22 On Tue, Jul 18, 2017 at 10:54:21AM +0530, Arvind Yadav wrote: > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by work > with const attribute_group. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav > --- > Changes in v2: > Change log typo was not correct. > > drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++-- > drivers/staging/unisys/visorbus/visorchipset.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Does not apply to my tree at all anymore, probably due to other visorbus patches I just took :( Please rebase and resend. thanks, greg k-h