Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751392AbdGRH1j (ORCPT ); Tue, 18 Jul 2017 03:27:39 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38532 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751026AbdGRH1i (ORCPT ); Tue, 18 Jul 2017 03:27:38 -0400 Date: Tue, 18 Jul 2017 09:27:32 +0200 From: Greg Kroah-Hartman To: Alexey Khoroshilov Cc: Jiri Slaby , Arnd Bergmann , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] serial: 8250: fix error handling in of_platform_serial_probe() Message-ID: <20170718072732.GA15573@kroah.com> References: <1498862969-4919-1-git-send-email-khoroshilov@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498862969-4919-1-git-send-email-khoroshilov@ispras.ru> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 690 Lines: 16 On Sat, Jul 01, 2017 at 01:49:29AM +0300, Alexey Khoroshilov wrote: > clk_disable_unprepare(info->clk) is missed in of_platform_serial_probe(), > while irq_dispose_mapping(port->irq) is missed in of_platform_serial_setup(). > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov > --- > drivers/tty/serial/8250/8250_of.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) I've had to drop this from my tree due to the obvious build warning it adds to the system. Always test-build your patches before sending them out, it makes maintainers grumpy when you do not do that :( greg k-h