Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751441AbdGRIAa (ORCPT ); Tue, 18 Jul 2017 04:00:30 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40300 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203AbdGRIA3 (ORCPT ); Tue, 18 Jul 2017 04:00:29 -0400 Date: Tue, 18 Jul 2017 10:00:23 +0200 From: Greg KH To: Arvind Yadav Cc: david.kershner@unisys.com, Timothy.Sell@unisys.com, bryan.thompson@unisys.com, jon.frisch@unisys.com, david.binder@unisys.com, sparmaintainer@unisys.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: unisys: visorbus: Constify attribute_group structures. Message-ID: <20170718080023.GA27652@kroah.com> References: <0e0fab8755868c167e689da7e92767cee7a321fc.1500364390.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0e0fab8755868c167e689da7e92767cee7a321fc.1500364390.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 658 Lines: 19 On Tue, Jul 18, 2017 at 01:24:42PM +0530, Arvind Yadav wrote: > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by work > with const attribute_group. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav > --- > drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++-- > drivers/staging/unisys/visorbus/visorchipset.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) What changed from the previous patches? Always include that below the --- line as maintainers have no short-term memory at all. v4? thanks, greg k-h