Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751488AbdGRIK1 (ORCPT ); Tue, 18 Jul 2017 04:10:27 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:35204 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751340AbdGRIKY (ORCPT ); Tue, 18 Jul 2017 04:10:24 -0400 Subject: Re: [PATCH v3] staging: unisys: visorbus: Constify attribute_group structures. To: Greg KH References: <0e0fab8755868c167e689da7e92767cee7a321fc.1500364390.git.arvind.yadav.cs@gmail.com> <20170718080023.GA27652@kroah.com> Cc: david.kershner@unisys.com, Timothy.Sell@unisys.com, bryan.thompson@unisys.com, jon.frisch@unisys.com, david.binder@unisys.com, sparmaintainer@unisys.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Arvind Yadav Message-ID: <971371a6-4c9b-7aec-6f85-c29ab6c4acb6@gmail.com> Date: Tue, 18 Jul 2017 13:39:50 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170718080023.GA27652@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 778 Lines: 23 Hi Greg, On Tuesday 18 July 2017 01:30 PM, Greg KH wrote: > On Tue, Jul 18, 2017 at 01:24:42PM +0530, Arvind Yadav wrote: >> attribute_group are not supposed to change at runtime. All functions >> working with attribute_group provided by work >> with const attribute_group. So mark the non-const structs as const. >> >> Signed-off-by: Arvind Yadav >> --- >> drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++-- >> drivers/staging/unisys/visorbus/visorchipset.c | 2 +- >> 2 files changed, 3 insertions(+), 3 deletions(-) > What changed from the previous patches? Always include that below the > --- line as maintainers have no short-term memory at all. > > v4? Sorry, I have missed it. :( > > thanks, > > greg k-h ~arvind