Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751415AbdGRIrE (ORCPT ); Tue, 18 Jul 2017 04:47:04 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:36617 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751341AbdGRIrB (ORCPT ); Tue, 18 Jul 2017 04:47:01 -0400 MIME-Version: 1.0 In-Reply-To: <1590546.5d4hGCCWgT@positron.chronox.de> References: <3910055.ntkqcq1Chb@positron.chronox.de> <1830340.t0pR7po4tk@positron.chronox.de> <1590546.5d4hGCCWgT@positron.chronox.de> From: Arnd Bergmann Date: Tue, 18 Jul 2017 10:47:00 +0200 X-Google-Sender-Auth: ZtTvk2KyTk98eGvo_QAYlCtRpKA Message-ID: Subject: Re: [RFC PATCH v12 2/4] random: conditionally compile code depending on LRNG To: =?UTF-8?Q?Stephan_M=C3=BCller?= Cc: "Jason A. Donenfeld" , Greg Kroah-Hartman , linux-crypto@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v6I8lBkB017350 Content-Length: 1203 Lines: 30 On Tue, Jul 18, 2017 at 10:37 AM, Stephan Müller wrote: > Am Dienstag, 18. Juli 2017, 10:13:55 CEST schrieb Arnd Bergmann: >> On Tue, Jul 18, 2017 at 9:58 AM, Stephan Müller wrote: >> > When selecting the LRNG for compilation, disable add_disk_randomness and >> > its supporting function. >> > >> > CC: Greg Kroah-Hartman >> > CC: Arnd Bergmann >> > CC: Jason A. Donenfeld >> > Signed-off-by: Stephan Mueller >> >> I think this needs a better explanation. Why do we ignore the extra >> entropy here? > > I was not sure whether to add all the details about the reason into the patch > submission. > > The reason is explained here in [1] page 3 and re-iterated in [2]. > Ok, got it. A half-sentence summary of that ("... to avoid adding the same event twice from interrupt and block") would be sufficient for the patch description, longer is also fine. Generally speaking, each patch description should describe why that particular patch is required rather than describe what it does (which in cases like this is plain to see from looking a few lines down). Arnd