Date: Tue, 18 Jul 2017 10:47:59 +0200 (CEST)
From: Julia Lawall <julia.lawall@lip6.fr>
To: Elena Reshetova <elena.reshetova@intel.com>
cc: linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr,
        Gilles Muller <Gilles.Muller@lip6.fr>, nicolas.palix@imag.fr,
        mmarek@suse.com, keescook@chromium.org, ishkamiel@gmail.com
Subject: Re: [PATCH] Coccinelle report script for refcounters
In-Reply-To: <1500364111-2192-1-git-send-email-elena.reshetova@intel.com>
Message-ID: <alpine.DEB.2.20.1707181047350.2529@hadrien>
References: <1500364111-2192-1-git-send-email-elena.reshetova@intel.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1243
Lines: 40


On Tue, 18 Jul 2017, Elena Reshetova wrote:

> The below script can be used to detect potential misusage
> of atomic_t type and API for reference counting purposes.
> Now when we have a dedicated refcount_t type and API with
> security protection implemented, people should be using it
> instead.
>
> Currently it still reports many occurences since we are
> nowhere near the end of our kernel-wide conversion execrise,
> but hopefully after couple of cycles more, the amount of
> output would be much more limited.
>
> Each script result must be analysed manually before any
> conversion, since refcount_t might not suit for certain
> purposes (for example if an object is not always destroyed
> upon refcounter reaching zero, if increments from zero are
> allowed in the code etc.)
>
> As we go further and get less results in output, we will
> improve the pattern to detect conversion cases more precisely.

The regexps are the best you can do?

julia

>
> Elena Reshetova (1):
>   Coccinelle: add atomic_as_refcounter script
>
>  scripts/coccinelle/api/atomic_as_refcounter.cocci | 102 ++++++++++++++++++++++
>  1 file changed, 102 insertions(+)
>  create mode 100644 scripts/coccinelle/api/atomic_as_refcounter.cocci
>
> --
> 2.7.4
>
>