Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751418AbdGRJDY (ORCPT ); Tue, 18 Jul 2017 05:03:24 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:35765 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751341AbdGRJDU (ORCPT ); Tue, 18 Jul 2017 05:03:20 -0400 MIME-Version: 1.0 In-Reply-To: <20170717102404.27191-3-andriy.shevchenko@linux.intel.com> References: <20170717102404.27191-1-andriy.shevchenko@linux.intel.com> <20170717102404.27191-3-andriy.shevchenko@linux.intel.com> From: Geert Uytterhoeven Date: Tue, 18 Jul 2017 11:03:18 +0200 X-Google-Sender-Auth: 8lQiyDtqlfePySgr9mA8WdBUIXA Message-ID: Subject: Re: [PATCH v2 2/5] ACPI / boot: Correct address space of __acpi_map_table() To: Andy Shevchenko Cc: "Rafael J . Wysocki" , Linux PM list , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , "the arch/x86 maintainers" , "linux-kernel@vger.kernel.org" , Hanjun Guo , ACPI Devel Maling List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1298 Lines: 34 Hi Andy, On Mon, Jul 17, 2017 at 12:24 PM, Andy Shevchenko wrote: > Sparse complains about wrong address space used in __acpi_map_table() > and in __acpi_unmap_table(). > > arch/x86/kernel/acpi/boot.c:127:29: warning: incorrect type in return expression (different address spaces) > arch/x86/kernel/acpi/boot.c:127:29: expected char * > arch/x86/kernel/acpi/boot.c:127:29: got void [noderef] * > arch/x86/kernel/acpi/boot.c:135:23: warning: incorrect type in argument 1 (different address spaces) > arch/x86/kernel/acpi/boot.c:135:23: expected void [noderef] *addr > arch/x86/kernel/acpi/boot.c:135:23: got char *map > > Correct address space to be in align of type of returned and passed > parameter. > > Signed-off-by: Andy Shevchenko > --- > arch/arm64/kernel/acpi.c | 4 ++-- Thanks for the update! I can confirm this fixes the arm64 build for me. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds