Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751511AbdGRJTt (ORCPT ); Tue, 18 Jul 2017 05:19:49 -0400 Received: from ozlabs.org ([103.22.144.67]:51577 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbdGRJTs (ORCPT ); Tue, 18 Jul 2017 05:19:48 -0400 From: Michael Ellerman To: Arnaldo Carvalho de Melo , Ravi Bangoria Cc: kjlx@templeofstupid.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf probe: Fix build failure for get_target_map() In-Reply-To: <20170717131108.GC10517@kernel.org> References: <1499305693-1599-4-git-send-email-kjlx@templeofstupid.com> <1500287542-6219-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <20170717131108.GC10517@kernel.org> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Tue, 18 Jul 2017 19:19:45 +1000 Message-ID: <874luaje4u.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 794 Lines: 22 Arnaldo Carvalho de Melo writes: > Em Mon, Jul 17, 2017 at 04:02:22PM +0530, Ravi Bangoria escreveu: >> Commit 801bc8193463 ("perf probe: Allow placing uprobes in >> alternate namespaces.") is causing a build failure on powerpc: >> >> error: incompatible type for argument 2 of 'get_target_map' >> map = get_target_map(pev->target, pev->uprobes); >> ^~~ >> >> Fix it by changing parameters of get_target_map(). > > Thanks, since this hasn't made it to Ingo I'll fold this into the patch > where the problem was introduced, adding credits to you, leaving a Link > to this message, so that we don't lose bisection in this area on > powerpc. Thanks. I just bisected to this commit too - should have checked the list first! :) cheers