Subject: Re: [PATCH 1/2] ARM: OMAP2+: hsmmc.c: Remove dead code
To: Ulf Hansson <ulf.hansson@linaro.org>
CC: Tony Lindgren <tony@atomide.com>, Russell King <linux@armlinux.org.uk>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-omap <linux-omap@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kishon <kishon@ti.com>, Ravikumar Kattekola <rk@ti.com>,
        Sekhar Nori <nsekhar@ti.com>, Linus Walleij <linus.walleij@linaro.org>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Peter Ujfalusi <peter.ujfalusi@ti.com>
References: <1500036404-5556-1-git-send-email-faiz_abbas@ti.com>
 <1500036404-5556-2-git-send-email-faiz_abbas@ti.com>
 <CAPDyKFpwb3T4PhQSyUwWDwpEnOwVDxLeK7hAMS0Q4P3tzPXXrQ@mail.gmail.com>
From: Faiz Abbas <faiz_abbas@ti.com>
Message-ID: <4d41e743-0971-18ea-59ef-6e2f869e42e8@ti.com>
Date: Tue, 18 Jul 2017 15:49:13 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <CAPDyKFpwb3T4PhQSyUwWDwpEnOwVDxLeK7hAMS0Q4P3tzPXXrQ@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1368
Lines: 43

Hi Ulfe,

I just wanted to make sure that no regressions happen on pandora board.
I have tested this on dra71x-evm.

Regards,
Faiz

On Monday 17 July 2017 06:38 PM, Ulf Hansson wrote:
> On 14 July 2017 at 14:46, Faiz Abbas <faiz_abbas@ti.com> wrote:
>> Most platforms using OMAP hsmmc driver have switched to device tree
>> for passing platform data to omap_hsmmc.c driver.
>>
>> The hsmmc.c file in mach-omap2 exists only to support pandora board
>> which uses wl1251 driver in legacy platform data mode.
>>
>> Hence, remove the dead code not used by the pandora board.
>>
>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> 
> I just got an ack from Tony to pick this up. So I did that (including
> the mmc change in patch 2) and intend to send this for 4.13 rcs, via
> my fixes branch in my mmc tree.
> 
> However the below comment for testing puzzles me. Either it's dead
> code or not, so then what is there to test? :-)
> 
> Anyway, it's available on my fixes and next branch, so let's see if
> zero build reports some issues.
> 
>> ---
>> This is only compile tested. Someone with a pandora board should help
>> test this for functionality.
>>
>>  arch/arm/mach-omap2/hsmmc.c | 239 +-------------------------------------------
>>  arch/arm/mach-omap2/hsmmc.h |   9 --
>>  2 files changed, 2 insertions(+), 246 deletions(-)
> 
> [...]
> 
> Kind regards
> Uffe
>