Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751602AbdGRKgK (ORCPT ); Tue, 18 Jul 2017 06:36:10 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:33170 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751531AbdGRKgI (ORCPT ); Tue, 18 Jul 2017 06:36:08 -0400 Date: Tue, 18 Jul 2017 18:35:42 +0800 From: Herbert Xu To: Arvind Yadav Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: sahara : make of_device_ids const. Message-ID: <20170718103542.GE6479@gondor.apana.org.au> References: <6324a0d5dc00bcc8f082d268a15b209ee6a4ee7a.1498563591.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6324a0d5dc00bcc8f082d268a15b209ee6a4ee7a.1498563591.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 788 Lines: 20 On Tue, Jun 27, 2017 at 05:11:23PM +0530, Arvind Yadav wrote: > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by work with const > of_device_ids. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 9759 2736 8 12503 30d7 drivers/crypto/sahara.o > > File size after constify: > text data bss dec hex filename > 10367 2128 8 12503 30d7 drivers/crypto/sahara.o > > Signed-off-by: Arvind Yadav Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt