Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752346AbdGRKjE (ORCPT ); Tue, 18 Jul 2017 06:39:04 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:33330 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751532AbdGRKjD (ORCPT ); Tue, 18 Jul 2017 06:39:03 -0400 Date: Tue, 18 Jul 2017 18:38:36 +0800 From: Herbert Xu To: "Gustavo A. R. Silva" Cc: "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: Re: [PATCH] crypto: brcm: add NULL check on of_match_device() return value Message-ID: <20170718103836.GS6479@gondor.apana.org.au> References: <20170707063333.GA18377@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170707063333.GA18377@embeddedgus> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 478 Lines: 13 On Fri, Jul 07, 2017 at 01:33:33AM -0500, Gustavo A. R. Silva wrote: > Check return value from call to of_match_device() > in order to prevent a NULL pointer dereference. > > In case of NULL print error message and return -ENODEV > > Signed-off-by: Gustavo A. R. Silva Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt