Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751854AbdGRL2f (ORCPT ); Tue, 18 Jul 2017 07:28:35 -0400 Received: from mga03.intel.com ([134.134.136.65]:40218 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751428AbdGRL2d (ORCPT ); Tue, 18 Jul 2017 07:28:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,377,1496127600"; d="scan'208";a="1173877325" Message-ID: <1500377308.1351.5.camel@linux.intel.com> Subject: Re: [PATCH] drm/i915: Explicit the connector name for DP link training result From: Paul Kocialkowski To: Jani Nikula , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Manasi Navare , Daniel Vetter , David Airlie Date: Tue, 18 Jul 2017 14:28:28 +0300 In-Reply-To: <8760eqb3fr.fsf@intel.com> References: <20170717142726.18761-1-paul.kocialkowski@linux.intel.com> <8760eqb3fr.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo, Finland Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.24.3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2390 Lines: 66 Hey, On Tue, 2017-07-18 at 10:38 +0300, Jani Nikula wrote: > On Mon, 17 Jul 2017, Paul Kocialkowski com> wrote: > > This adds the connector name when printing a debug message about the > > DP > > link training result. It is useful to figure out what connector is > > failing when multiple DP connectors are used. > > Perhaps more consistent would be using a prefix like this: > > DRM_DEBUG_KMS("[CONNECTOR:%d:%s] bla bla blaa\n", > connector->base.base.id, connector->base.name); You are definitely right, this is what is used all over the place in the driver, so I should stick to it. Thanks for the suggestion, I will send out v2 in that direction shortly. Cheers, Paul > > Signed-off-by: Paul Kocialkowski > > --- > > drivers/gpu/drm/i915/intel_dp_link_training.c | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c > > b/drivers/gpu/drm/i915/intel_dp_link_training.c > > index b79c1c0e404c..75a411c94ce5 100644 > > --- a/drivers/gpu/drm/i915/intel_dp_link_training.c > > +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c > > @@ -321,13 +321,15 @@ intel_dp_start_link_train(struct intel_dp > > *intel_dp) > > if (!intel_dp_link_training_channel_equalization(intel_dp)) > > goto failure_handling; > > > > - DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane > > count = %d", > > - intel_dp->link_rate, intel_dp->lane_count); > > + DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane > > count = %d for connector %s", > > + intel_dp->link_rate, intel_dp->lane_count, > > + intel_connector->base.name); > > return; > > > > failure_handling: > > - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane > > count = %d", > > - intel_dp->link_rate, intel_dp->lane_count); > > + DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane > > count = %d for connector %s", > > + intel_dp->link_rate, intel_dp->lane_count, > > + intel_connector->base.name); > > if (!intel_dp_get_link_train_fallback_values(intel_dp, > > intel_dp- > > >link_rate, > > intel_dp- > > >lane_count)) > > -- Paul Kocialkowski Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo, Finland