MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Tue, 18 Jul 2017 17:19:46 +0530
From: kgunda@codeaurora.org
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Abhijeet Dharmapurikar <adharmap@codeaurora.org>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Subbaraman Narayanamurthy <subbaram@codeaurora.org>,
        David Collins <collinsd@codeaurora.org>, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, adharmap@quicinc.com,
        aghayal@qti.qualcomm.com, linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH V1 15/15] spmi: pmic-arb: instantiate spmi_devices at
 arch_initcall
In-Reply-To: <20170531220729.GI20170@codeaurora.org>
References: <1496147943-25822-1-git-send-email-kgunda@codeaurora.org>
 <1496147943-25822-16-git-send-email-kgunda@codeaurora.org>
 <20170531220729.GI20170@codeaurora.org>
Message-ID: <96f198cac01dbfd72d478e9965f02645@codeaurora.org>
User-Agent: Roundcube Webmail/1.2.5
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 778
Lines: 25

On 2017-06-01 03:37, Stephen Boyd wrote:
> On 05/30, Kiran Gunda wrote:
>> @@ -1384,7 +1384,12 @@ static int spmi_pmic_arb_remove(struct 
>> platform_device *pdev)
>>  		.of_match_table = spmi_pmic_arb_match_table,
>>  	},
>>  };
>> -module_platform_driver(spmi_pmic_arb_driver);
>> +
>> +int __init spmi_pmic_arb_init(void)
> 
> Missing static.
> 
>> +{
>> +	return platform_driver_register(&spmi_pmic_arb_driver);
>> +}
>> +arch_initcall(spmi_pmic_arb_init);
> 
> We also lost module removal. Probably nobody tests it, but still
> no mention of that in commit text.
> 
> I'm not sure we need this at all though. Is there something that
> needs to probe early? Indicating what that is in the commit text
> would be helpful.
Dropped out this patch. As this is no more required.