Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751461AbdGRMBX (ORCPT ); Tue, 18 Jul 2017 08:01:23 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:35772 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbdGRMBV (ORCPT ); Tue, 18 Jul 2017 08:01:21 -0400 MIME-Version: 1.0 In-Reply-To: <20170718101730.2541-1-jonas.gorski@gmail.com> References: <20170718101730.2541-1-jonas.gorski@gmail.com> From: Geert Uytterhoeven Date: Tue, 18 Jul 2017 14:01:19 +0200 X-Google-Sender-Auth: RwdT_UYhZpTMBER69EHulAnwCwY Message-ID: Subject: Re: [PATCH 0/9] make clk_get_rate implementations behavior more consistent To: Jonas Gorski Cc: "adi-buildroot-devel@lists.sourceforge.net" , bcm-kernel-feedback-list@broadcom.com, "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-m68k , Linux MIPS Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2316 Lines: 58 Hi Jonas, On Tue, Jul 18, 2017 at 12:17 PM, Jonas Gorski wrote: > The common clock and several other clock API implementations allow > calling clk_get_rate with a NULL pointer. While not specified as > expected behavior of the API, device drivers have come to rely on that, > causing them to OOPS when run on a platform with a different clock API > implementation. > > Fix this by making sure all clk_get_rate implementations handle > NULL clocks instead of OOPSing. > > While some custom implementations even allow ERR_PTR()s, I decided > against that as IIRC the usual idea is that errors should be handled and > not silently carried over. > > Cc: adi-buildroot-devel@lists.sourceforge.net > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-m68k@lists.linux-m68k.org > Cc: linux-mips@linux-mips.org > > Jonas Gorski (9): > ARM: ep93xx: allow NULL clock for clk_get_rate > ARM: mmp: allow NULL clock for clk_get_rate > blackfin: bf609: allow NULL clock for clk_get_rate > m68k: allow NULL clock for clk_get_rate > MIPS: AR7: allow NULL clock for clk_get_rate > MIPS: BCM63XX: allow NULL clock for clk_get_rate > MIPS: Loongson 2F: allow NULL clock for clk_get_rate > MIPS: ralink: allow NULL clock for clk_get_rate > unicore32: allow NULL clock for clk_get_rate > > arch/arm/mach-ep93xx/clock.c | 3 +++ > arch/arm/mach-mmp/clock.c | 4 +++- > arch/blackfin/mach-bf609/clock.c | 2 +- > arch/m68k/coldfire/clk.c | 3 +++ > arch/mips/ar7/clock.c | 3 +++ > arch/mips/bcm63xx/clk.c | 3 +++ > arch/mips/loongson64/lemote-2f/clock.c | 3 +++ > arch/mips/ralink/clk.c | 3 +++ > arch/unicore32/kernel/clock.c | 3 +++ > 9 files changed, 25 insertions(+), 2 deletions(-) For the whole series: Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds