Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752148AbdGROQm (ORCPT ); Tue, 18 Jul 2017 10:16:42 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:52845 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751413AbdGROQj (ORCPT ); Tue, 18 Jul 2017 10:16:39 -0400 X-ME-Sender: X-Sasl-enc: gEAYS16fkGLkIsCChENZoDhzQilKFY+vvKRSYrYcoqsR 1500387398 Date: Tue, 18 Jul 2017 16:16:33 +0200 From: Greg Kroah-Hartman To: Johannes Poehlmann Cc: linux-kernel@vger.kernel.org, Evgeniy Polyakov Subject: Re: [PATCH v3 4/4] w1: ds1wm: add messages to make incorporation in mfd-drivers easier Message-ID: <20170718141633.GD18857@kroah.com> References: <6a03463f-7e93-8ee7-d56f-aaed1e2befba@izt-labs.de> <1500377213-1117-5-git-send-email-johannes.poehlmann@izt-labs.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1500377213-1117-5-git-send-email-johannes.poehlmann@izt-labs.de> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1465 Lines: 51 On Tue, Jul 18, 2017 at 01:26:53PM +0200, Johannes Poehlmann wrote: > Signed-off-by: Johannes Poehlmann > Acked-by: Evgeniy Polyakov > --- > drivers/w1/masters/ds1wm.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) And here as well. > > diff --git a/drivers/w1/masters/ds1wm.c b/drivers/w1/masters/ds1wm.c > index 7cb4460..76b4573 100644 > --- a/drivers/w1/masters/ds1wm.c > +++ b/drivers/w1/masters/ds1wm.c > @@ -580,8 +580,14 @@ static int ds1wm_probe(struct platform_device *pdev) > > ret = devm_request_irq(&pdev->dev, ds1wm_data->irq, ds1wm_isr, > IRQF_SHARED, "ds1wm", ds1wm_data); > - if (ret) > + if (ret) { > + dev_err(&ds1wm_data->pdev->dev, > + "devm_request_irq %d failed with errno %d\n", > + ds1wm_data->irq, > + ret); > + > return ret; > + } > > ds1wm_up(ds1wm_data); > > @@ -591,6 +597,13 @@ static int ds1wm_probe(struct platform_device *pdev) > if (ret) > goto err; > > + dev_info(&ds1wm_data->pdev->dev, > + "ds1wm: probe successful, IAS: %d, rec.delay: %d, clockrate: %d, bus-shift: %d, is Hw Big Endian: %d\n", > + plat->active_high, > + plat->reset_recover_delay, > + plat->clock_rate, > + ds1wm_data->bus_shift, > + ds1wm_data->is_hw_big_endian); Ick, why be so noisy? Drivers should be quiet unless something bad happens, they should not print random things when devices are found if at all possible. thanks, greg k-h