From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
To: Arnd Bergmann <arnd@arndb.de>
CC: gregkh <gregkh@linuxfoundation.org>, Stuart Yoder <stuyoder@gmail.com>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        Marc Zyngier <marc.zyngier@arm.com>, Alexander Graf <agraf@suse.de>,
        Robin Murphy <robin.murphy@arm.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        "Ruxandra Ioana Radulescu" <ruxandra.radulescu@nxp.com>,
        Bharat Bhushan <bharat.bhushan@nxp.com>,
        Catalin Horghidan <catalin.horghidan@nxp.com>,
        "Leo Li" <leoyang.li@nxp.com>, Roy Pledge <roy.pledge@nxp.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 8/8] staging: fsl-mc: allow the driver compile
 multi-arch
Thread-Topic: [PATCH v2 8/8] staging: fsl-mc: allow the driver compile
 multi-arch
Thread-Index: AQHS/8sd6hE3b4UaxEG5mfgBafl8kqJZo9sAgAAC8IA=
Date: Tue, 18 Jul 2017 14:36:07 +0000
Message-ID: <596E1CD7.1050909@nxp.com>
References: <20170718133723.12709-1-laurentiu.tudor@nxp.com>
 <20170718133723.12709-9-laurentiu.tudor@nxp.com>
 <CAK8P3a0WvNgk5eXQoPpXiLwOS_wB1NdfCyPtiKMys3qqEwHjDw@mail.gmail.com>
In-Reply-To: <CAK8P3a0WvNgk5eXQoPpXiLwOS_wB1NdfCyPtiKMys3qqEwHjDw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-ID: <B61D72A788D84D408D20B5B8B99426A1@eurprd04.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2017 14:36:07.7552
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2560
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id v6IEaKwM007024
Content-Length: 1312
Lines: 42

Hi Arnd,

On 07/18/2017 05:25 PM, Arnd Bergmann wrote:
> On Tue, Jul 18, 2017 at 3:37 PM,  <laurentiu.tudor@nxp.com> wrote:
>
>> --- a/drivers/staging/fsl-dpaa2/Kconfig
>> +++ b/drivers/staging/fsl-dpaa2/Kconfig
>> @@ -4,7 +4,7 @@
>>
>>   config FSL_DPAA2
>>          bool "Freescale DPAA2 devices"
>> -       depends on FSL_MC_BUS
>> +       depends on FSL_MC_BUS && ARCH_LAYERSCAPE
>>          ---help---
>>            Build drivers for Freescale DataPath Acceleration
>>            Architecture (DPAA2) family of SoCs.
>
> I would probably leave the dependency in there conditionally, like
>
>           depends on ARCH_LAYERSCAPE || COMPILE_TEST
>
> That way, we can build the driver on all architectures with "make allmodconfig"
> or "make randconfig", but regular users that disable COMPILE_TEST
> won't be bothered by the extra config options unless they have the
> right hardware.
>

Good point, I'll take care of it. But don't you mean COMPILE_TEST be 
added on the actual MC_BUS config, like so:

  config FSL_MC_BUS
  	bool "QorIQ DPAA2 fsl-mc bus driver"
-	depends on OF && ARCH_LAYERSCAPE
+	depends on OF && (ARCH_LAYERSCAPE || COMPILE_TEST)
  	select GENERIC_MSI_IRQ_DOMAIN
?

The other drivers that depend on the MC_BUS won't compile on other 
architectures.

---
Thanks & Best Regards, Laurentiu