Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751915AbdGROh2 (ORCPT ); Tue, 18 Jul 2017 10:37:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:35494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751455AbdGROhZ (ORCPT ); Tue, 18 Jul 2017 10:37:25 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2D9A22C99 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh@kernel.org MIME-Version: 1.0 In-Reply-To: References: <491bf615-f1d2-13ff-fa6e-fe5350a0b3b0@siemens.com> <20170717174825.p2oflpvbd5ns6xx3@rob-hp-laptop> From: Rob Herring Date: Tue, 18 Jul 2017 09:37:03 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] gpio-exar: Use correct property prefix and document bindings To: Jan Kiszka Cc: Linus Walleij , Mark Rutland , linux-gpio , devicetree , Linux Kernel Mailing List , Andy Shevchenko , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 720 Lines: 16 On Mon, Jul 17, 2017 at 1:20 PM, Jan Kiszka wrote: > On 2017-07-17 19:48, Rob Herring wrote: >> On Thu, Jul 13, 2017 at 08:44:26AM +0200, Jan Kiszka wrote: >>> The device-specific property should be prefixed with the vendor name >>> Change this and document the bindings of this platform device. >> >> You are breaking backwards compatibility. You minimally need to state >> that and why that is okay in this case. > > There is no previous version yet: The patch that introduced this just > entered for 4.13. Linus remarked that "linux," is the wrong prefix and > wanted this to be changed before this version becomes final. Please describe this in the commit message and add a Fixes tag. Rob