Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751511AbdGRPpm (ORCPT ); Tue, 18 Jul 2017 11:45:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:37848 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751366AbdGRPpl (ORCPT ); Tue, 18 Jul 2017 11:45:41 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7E3F22C86 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Tue, 18 Jul 2017 12:45:38 -0300 From: Arnaldo Carvalho de Melo To: Michael Ellerman Cc: Ravi Bangoria , kjlx@templeofstupid.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf probe: Fix build failure for get_target_map() Message-ID: <20170718154538.GF10517@kernel.org> References: <1499305693-1599-4-git-send-email-kjlx@templeofstupid.com> <1500287542-6219-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <20170717131108.GC10517@kernel.org> <874luaje4u.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <874luaje4u.fsf@concordia.ellerman.id.au> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1040 Lines: 28 Em Tue, Jul 18, 2017 at 07:19:45PM +1000, Michael Ellerman escreveu: > Arnaldo Carvalho de Melo writes: > > > Em Mon, Jul 17, 2017 at 04:02:22PM +0530, Ravi Bangoria escreveu: > >> Commit 801bc8193463 ("perf probe: Allow placing uprobes in > >> alternate namespaces.") is causing a build failure on powerpc: > >> > >> error: incompatible type for argument 2 of 'get_target_map' > >> map = get_target_map(pev->target, pev->uprobes); > >> ^~~ > >> > >> Fix it by changing parameters of get_target_map(). > > > > Thanks, since this hasn't made it to Ingo I'll fold this into the patch > > where the problem was introduced, adding credits to you, leaving a Link > > to this message, so that we don't lose bisection in this area on > > powerpc. > > Thanks. > > I just bisected to this commit too - should have checked the list first! :) :-) I just re-ammended this cset to cover the !HAVE_DWARF_SUPPORT build as well, just re-force-pushed acme/perf/core with this fix. - Arnaldo