Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751430AbdGRP7t (ORCPT ); Tue, 18 Jul 2017 11:59:49 -0400 Received: from mga07.intel.com ([134.134.136.100]:32484 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751353AbdGRP7s (ORCPT ); Tue, 18 Jul 2017 11:59:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,378,1496127600"; d="scan'208";a="994349765" Date: Tue, 18 Jul 2017 21:32:33 +0530 From: Vinod Koul To: Arvind Yadav Cc: dan.j.williams@intel.com, dave.jiang@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: ioat: constify pci_device_id. Message-ID: <20170718160232.GU3053@localhost> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 582 Lines: 17 On Mon, Jul 17, 2017 at 09:39:00PM +0530, Arvind Yadav wrote: > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by work with > const pci_device_id. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 12582 3056 16 15654 3d26 drivers/dma/ioat/init.o > > File size After adding 'const': > text data bss dec hex filename > 14773 865 16 15654 3d26 drivers/dma/ioat/init.o Applied, thanks -- ~Vinod