Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751809AbdGRQIy (ORCPT <rfc822;w@1wt.eu>);
        Tue, 18 Jul 2017 12:08:54 -0400
Received: from mail-pg0-f66.google.com ([74.125.83.66]:35330 "EHLO
        mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751612AbdGRQIv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 18 Jul 2017 12:08:51 -0400
Date: Wed, 19 Jul 2017 01:07:56 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
        Milian Wolff <milian.wolff@kdab.com>, kernel-team@lge.com
Subject: Re: [PATCH v2 0/9] perf annotate: Fix --show-total-period and
 support --show-nr-samples
Message-ID: <20170718160756.GA12241@danjae.aot.lge.com>
References: <1499967944-15316-1-git-send-email-treeze.taeung@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1499967944-15316-1-git-send-email-treeze.taeung@gmail.com>
User-Agent: Mutt/1.8.2 (2017-04-18)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2494
Lines: 71

Hi Taeung,

On Fri, Jul 14, 2017 at 02:45:44AM +0900, Taeung Song wrote:
> Hello,
> 
> Currently the --show-total-period option of perf-annotate
> is different from perf-report's.
> 
> It has two problem like below:
> (Reported by Namhyung Kim and Milian Wolff)
> 
>   1) Wrong column i.e. 'Percent' (even though using --show-total-period)
>   2) Show number of samples, not period
> 
> So fix this option on both the annotate stdio and TUI browser.
> And support --show-nr-samples into perf-anntate
> so that it correpond with perf-report's.
> 
> The code is available on 'perf/ann-fix-period-v2' branch at
> 
>   git://github.com/taeung/linux-perf.git
> 
> Thanks,
> Taeung
> 
> v2:
> - Separate the first patch into respective paches for easy review (Arnaldo)
> - Add a patch to introduce 'struct sym_hist_entry' (Arnaldo)
> - disasm__calc_percent() could receive a pointer to a struct sym_hist_entry
>   instead of two pointer (Arnaldo)
> - Add a sym_hist_entry into struct disasm_line_samples (Arnaldo) 
> - Fix a case that can't switch 'the total period view' to
>   'the number of samples view' on the annotate TUI browser (Arnaldo)
> - Calculate the percentage with 'period', not number of samples
> 
> Taeung Song (9):
>   perf annotate: Introduce struct sym_hist_entry
>   perf annotate: Properly rename 'sum' to 'total_samples' in struct
>     sym_hist
>   perf annotate: Fix wrong --show-total-period option showing number of
>     samples
>   perf annotate: Show the proper header when using --show-total-period
>   perf anntoate browser: Fix the toggle total period view to show
>     period, not number of samples
>   perf annotate browser: Show the proper header when using
>     --show-total-period
>   perf annotate: Support --show-nr-samples option
>   perf annotate browser: Support the toggle number of samples with a 'e'
>     hotkey
>   perf annotate: Use the sample period when calculating the percentage

It seems I didn't receive the patch 3 and 5 for some reason.  Anyway
I have a few comments.

Thanks,
Namhyung


> 
>  tools/perf/builtin-annotate.c     |   6 +-
>  tools/perf/builtin-report.c       |  13 ++--
>  tools/perf/builtin-top.c          |   6 +-
>  tools/perf/ui/browsers/annotate.c |  42 ++++++++++---
>  tools/perf/ui/gtk/annotate.c      |   4 +-
>  tools/perf/util/annotate.c        | 125 ++++++++++++++++++++++++++------------
>  tools/perf/util/annotate.h        |  15 +++--
>  7 files changed, 148 insertions(+), 63 deletions(-)
> 
> -- 
> 2.7.4
>