Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751487AbdGRQoA (ORCPT ); Tue, 18 Jul 2017 12:44:00 -0400 Received: from mail.skyhub.de ([5.9.137.197]:37398 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751363AbdGRQn4 (ORCPT ); Tue, 18 Jul 2017 12:43:56 -0400 Date: Tue, 18 Jul 2017 18:43:50 +0200 From: Borislav Petkov To: "Kani, Toshimitsu" Cc: "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "mchehab@kernel.org" , "rjw@rjwysocki.net" , "srinivas.pandruvada@linux.intel.com" , "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-edac@vger.kernel.org" Subject: Re: [PATCH 1/3] ACPI / blacklist: add acpi_match_oemlist() interface Message-ID: <20170718164350.GB22334@nazgul.tnic> References: <20170717215912.26070-1-toshi.kani@hpe.com> <20170717215912.26070-2-toshi.kani@hpe.com> <20170718053455.GA8736@nazgul.tnic> <1500392379.2042.13.camel@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1500392379.2042.13.camel@hpe.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 736 Lines: 30 On Tue, Jul 18, 2017 at 03:48:54PM +0000, Kani, Toshimitsu wrote: > This patch defines 'struct acpi_oemlist' in "include/linux/acpi.h" as a I see that. > common structure, and replaces this specific 'struct acpi_blacklist'. And what makes acpi_oemlist "common" and acpi_blacklist "specific"? So let me save you some time - "oemlist" is more specific than "blacklist" and I can imagine a blacklist item not always being oem-specific. What I'm hinting at is, don't change that name. acpi_blacklist is just fine. > Agreed. Will change to a shorter name like below. > > enum acpi_oemlist_pred predicate; enum acpi_predicate pred; is even better. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --