Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751603AbdGRRZW (ORCPT ); Tue, 18 Jul 2017 13:25:22 -0400 Received: from g4t3427.houston.hpe.com ([15.241.140.73]:57360 "EHLO g4t3427.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751405AbdGRRZT (ORCPT ); Tue, 18 Jul 2017 13:25:19 -0400 From: "Kani, Toshimitsu" To: "bp@alien8.de" CC: "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "mchehab@kernel.org" , "rjw@rjwysocki.net" , "srinivas.pandruvada@linux.intel.com" , "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-edac@vger.kernel.org" Subject: Re: [PATCH 1/3] ACPI / blacklist: add acpi_match_oemlist() interface Thread-Topic: [PATCH 1/3] ACPI / blacklist: add acpi_match_oemlist() interface Thread-Index: AQHS/0k82DJdcf3Cl0iqbrqG8JixhKJZEJmAgACo9oCAABHvAIAACOAA Date: Tue, 18 Jul 2017 17:24:50 +0000 Message-ID: <1500398136.2042.17.camel@hpe.com> References: <20170717215912.26070-1-toshi.kani@hpe.com> <20170717215912.26070-2-toshi.kani@hpe.com> <20170718053455.GA8736@nazgul.tnic> <1500392379.2042.13.camel@hpe.com> <20170718164350.GB22334@nazgul.tnic> In-Reply-To: <20170718164350.GB22334@nazgul.tnic> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=none action=none header.from=hpe.com; x-originating-ip: [15.219.147.8] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DF4PR84MB0186;7:9xE9ldd4zRzebdCj47UZKMStgAWrDyMy2DaB9bWVmEXAyZA3b/IV7dwJIrqchQR6yOs5fSR0A+M8PaESXw4gCeNM1oGmxe0QgzLfz9kH5hce59HW/6erem+uV4lrin7bzhjbCB9T/2wERBR5zqHgdt26yIMw2yZ6Mdtk1JEzLlw3vVXeAMSQEP6qpgYYaSpukxpcEUluoZxn79dHsQNWTKgqoiQMa3qbWXAi/NdR8pFdnUaJm7vKFEBZbHkjEfwQ2inMPsbq2r5a6yR3wUcfBO1gpKeinBWCWu4Exq/p+8MskkpbyJuiTL+QGpENcFofRaI8LbZxRHK0d117+iu9eoqo3mU3NLimxPAWlNpoJtjNDQIfajn17BuzNGaF4THcQq0oXlHPP1u4gWHzAOiKqi2HVXUj05ps5HRnLOsDInAM6HRvzKzmms67Z9jYecusqk4FN94WvUwPCst2n7qR0hAEIA8Ej//DqduzrNQABw3r0rvH4DJt3GRryRlVwRCDbs4PUm+Ej8bmbWQmMIlmtTkrzTGAKuSwPN04kfmWvFJHmAcGhUMh/V9NYmL5bspn0/zGvJ42Tt5iUMbfYKogAdzK+EPuWXxPQHaKVGWo3KToR34XvOG/QWc25HAQ1Jmhidiz5a1wU1NnVhVtnImG8yTX/DQEcZPnMFOGv+cjnOCvOEUx1tlR6lEjLQdrmaCFf7lvevZgn6PF6ntzbhT+3ZzE3qjEBJRbooOga8hZoGGsI/CbDJc8Z8sdloLgVLvgiiP+7uzdGnHIJEeCugpp9Ql8PArtfJvrxJq466cDtEg= x-ms-office365-filtering-correlation-id: 6bcd6335-7516-4efc-ecd1-08d4ce01e599 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DF4PR84MB0186; x-ms-traffictypediagnostic: DF4PR84MB0186: x-exchange-antispam-report-test: UriScan:(236129657087228); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(2017060910075)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123560025)(20161123564025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DF4PR84MB0186;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DF4PR84MB0186; x-forefront-prvs: 037291602B x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39840400002)(39450400003)(39860400002)(39850400002)(39410400002)(39400400002)(24454002)(377424004)(6116002)(6486002)(3660700001)(77096006)(25786009)(8676002)(14454004)(53936002)(8936002)(5640700003)(66066001)(36756003)(3280700002)(1730700003)(6512007)(103116003)(6916009)(54906002)(2950100002)(6246003)(6436002)(110136004)(81166006)(38730400002)(5660300001)(2501003)(33646002)(7736002)(229853002)(102836003)(189998001)(86362001)(478600001)(2900100001)(305945005)(54356999)(76176999)(50986999)(93886004)(2351001)(4326008)(6506006)(2906002)(3846002);DIR:OUT;SFP:1102;SCL:1;SRVR:DF4PR84MB0186;H:DF4PR84MB0187.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <1317337B94B104408B916B64B3314622@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2017 17:24:50.6879 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR84MB0186 X-OriginatorOrg: hpe.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v6IHPRcD018981 Content-Length: 1000 Lines: 35 On Tue, 2017-07-18 at 18:43 +0200, Borislav Petkov wrote: > On Tue, Jul 18, 2017 at 03:48:54PM +0000, Kani, Toshimitsu wrote: > > This patch defines 'struct acpi_oemlist' in "include/linux/acpi.h" > > as a > > I see that. > > > common structure, and replaces this specific 'struct > > acpi_blacklist'. > > And what makes acpi_oemlist "common" and acpi_blacklist "specific"? > > So let me save you some time - "oemlist" is more specific than > "blacklist" and I can imagine a blacklist item not always being > oem-specific. > > What I'm hinting at is, don't change that name. acpi_blacklist is > just fine. Well, a list does not need to be a black-list. It can be a white-list or anything that matters. The caller defines the usage of a list. So, I tried to avoid putting any usage to the structure name. > > Agreed.  Will change to a shorter name like below.  > > > > enum acpi_oemlist_pred predicate; > > enum acpi_predicate pred; > > is even better. Sounds good. Thanks, -Toshi