Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751828AbdGRRqo (ORCPT ); Tue, 18 Jul 2017 13:46:44 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:13062 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751671AbdGRRqk (ORCPT ); Tue, 18 Jul 2017 13:46:40 -0400 Subject: Re: [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function To: Suman Anna , , References: <1500375436-9435-1-git-send-email-j-keerthy@ti.com> <1500375436-9435-3-git-send-email-j-keerthy@ti.com> CC: , , , , , , From: Keerthy Message-ID: Date: Tue, 18 Jul 2017 23:16:07 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1393 Lines: 57 On Tuesday 18 July 2017 10:24 PM, Suman Anna wrote: > Hi Keerthy, > > On 07/18/2017 05:57 AM, Keerthy wrote: >> Currently davinci_gpio_irq_setup return value is ignored. Handle the >> return value appropriately. >> >> Signed-off-by: Keerthy >> --- >> drivers/gpio/gpio-davinci.c | 18 +++++++++++++----- >> 1 file changed, 13 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c >> index 2c88054..932f270 100644 >> --- a/drivers/gpio/gpio-davinci.c >> +++ b/drivers/gpio/gpio-davinci.c >> @@ -233,15 +233,23 @@ static int davinci_gpio_probe(struct platform_device *pdev) >> chips->regs[bank] = gpio_base + offset_array[bank]; >> >> ret = devm_gpiochip_add_data(dev, &chips->chip, chips); >> + if (ret) >> + goto err; >> + >> + platform_set_drvdata(pdev, chips); >> + ret = davinci_gpio_irq_setup(pdev); >> if (ret) { >> - ctrl_num = 0; >> - bank_base = 0; >> - return ret; >> + platform_set_drvdata(pdev, NULL); > > This is not needed, driver core will set this automatically if probe fails. okay. I will remove this. > >> + goto err; >> } >> >> - platform_set_drvdata(pdev, chips); >> - davinci_gpio_irq_setup(pdev); >> return 0; >> + >> +err: >> + ctrl_num = 0; >> + bank_base = 0; > > Same comments as on Patch 1. Yup will fix this as i have done with Patch 1. > > regards > Suman >