Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751565AbdGRRtP (ORCPT ); Tue, 18 Jul 2017 13:49:15 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:56300 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751424AbdGRRtO (ORCPT ); Tue, 18 Jul 2017 13:49:14 -0400 Subject: Re: [PATCH 3/4] gpio: davinci: Add a separate compatible for keystone-k2g soc To: Sekhar Nori , , References: <1500375436-9435-1-git-send-email-j-keerthy@ti.com> <1500375436-9435-4-git-send-email-j-keerthy@ti.com> <902db353-2db1-fa86-5f96-541082348a35@ti.com> CC: , , , , , , From: Keerthy Message-ID: <8551db79-611e-e8f3-3756-ef4930760924@ti.com> Date: Tue, 18 Jul 2017 23:18:41 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <902db353-2db1-fa86-5f96-541082348a35@ti.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2151 Lines: 54 On Tuesday 18 July 2017 05:01 PM, Sekhar Nori wrote: > Hi Keerthy, > > On Tuesday 18 July 2017 04:27 PM, Keerthy wrote: >> Add a separate compatible for keystone-k2g soc >> >> Signed-off-by: Keerthy >> --- >> Documentation/devicetree/bindings/gpio/gpio-davinci.txt | 3 ++- >> drivers/gpio/gpio-davinci.c | 1 + >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >> index 5079ba7..1a5c1a2 100644 >> --- a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >> +++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >> @@ -1,7 +1,8 @@ >> Davinci/Keystone GPIO controller bindings >> >> Required Properties: >> -- compatible: should be "ti,dm6441-gpio", "ti,keystone-gpio" >> +- compatible: should be "ti,dm6441-gpio", "ti,keystone-gpio", >> + "ti,keystone-k2g-gpio" >> >> - reg: Physical base address of the controller and the size of memory mapped >> registers. >> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c >> index 932f270..a8d8dd9 100644 >> --- a/drivers/gpio/gpio-davinci.c >> +++ b/drivers/gpio/gpio-davinci.c >> @@ -610,6 +610,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev) >> static const struct of_device_id davinci_gpio_ids[] = { >> { .compatible = "ti,keystone-gpio", keystone_gpio_get_irq_chip}, >> { .compatible = "ti,dm6441-gpio", davinci_gpio_get_irq_chip}, >> + { .compatible = "ti,keystone-k2g-gpio", keystone_gpio_get_irq_chip}, > > You don't have to add compatible matching to the driver if you don't > need any special handling for K2G ATM. Your dts should have: > > compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio"; > > this way, the driver continues to probe using "ti,keystone-gpio", and > when you really discover a need to do some special handling for K2G, a > kernel update will do without the need for a DT update. Sure that is better to do as currently i do not see any differences between k2g and other k2 devices. > > Thanks, > Sekhar >