Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751836AbdGRSyI (ORCPT <rfc822;w@1wt.eu>);
        Tue, 18 Jul 2017 14:54:08 -0400
Received: from conssluserg-01.nifty.com ([210.131.2.80]:56140 "EHLO
        conssluserg-01.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751392AbdGRSyH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 18 Jul 2017 14:54:07 -0400
DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com v6IIs1Yv011662
X-Nifty-SrcIP: [209.85.161.180]
MIME-Version: 1.0
In-Reply-To: <20170718101730.2541-4-jonas.gorski@gmail.com>
References: <20170718101730.2541-1-jonas.gorski@gmail.com> <20170718101730.2541-4-jonas.gorski@gmail.com>
From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Wed, 19 Jul 2017 03:54:00 +0900
X-Gmail-Original-Message-ID: <CAK7LNASr2bPuqqPaz2vPWLXUyVoa7oPtRVfyUDEx1B6YU2Gvxw@mail.gmail.com>
Message-ID: <CAK7LNASr2bPuqqPaz2vPWLXUyVoa7oPtRVfyUDEx1B6YU2Gvxw@mail.gmail.com>
Subject: Re: [PATCH 3/9] blackfin: bf609: allow NULL clock for clk_get_rate
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: Steven Miao <realmz6@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        adi-buildroot-devel@lists.sourceforge.net,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1418
Lines: 47

2017-07-18 19:17 GMT+09:00 Jonas Gorski <jonas.gorski@gmail.com>:
> Make the behaviour of clk_get_rate consistent with common clk's
> clk_get_rate by accepting NULL clocks as parameter. Some device
> drivers rely on this, and will cause an OOPS otherwise.
>
> Fixes: 969003152aa9 ("blackfin: bf60x: add clock support")
> Cc: Steven Miao <realmz6@gmail.com>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>

This Cc can be replaced with

Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Thank you.


> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: adi-buildroot-devel@lists.sourceforge.net
> Cc: linux-kernel@vger.kernel.org
> Reported-by: Mathias Kresin <dev@kresin.me>
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
> ---
>  arch/blackfin/mach-bf609/clock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/blackfin/mach-bf609/clock.c b/arch/blackfin/mach-bf609/clock.c
> index 392a59b9a504..21a0ec18829f 100644
> --- a/arch/blackfin/mach-bf609/clock.c
> +++ b/arch/blackfin/mach-bf609/clock.c
> @@ -109,7 +109,7 @@ EXPORT_SYMBOL(clk_disable);
>  unsigned long clk_get_rate(struct clk *clk)
>  {
>         unsigned long ret = 0;
> -       if (clk->ops && clk->ops->get_rate)
> +       if (clk && clk->ops && clk->ops->get_rate)
>                 ret = clk->ops->get_rate(clk);
>         return ret;
>  }
> --
> 2.11.0
>



-- 
Best Regards
Masahiro Yamada