Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751935AbdGRSzz (ORCPT ); Tue, 18 Jul 2017 14:55:55 -0400 Received: from mga02.intel.com ([134.134.136.20]:41636 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751392AbdGRSzy (ORCPT ); Tue, 18 Jul 2017 14:55:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,378,1496127600"; d="scan'208";a="112774002" From: "Pandiyan, Dhinakaran" To: "paul.kocialkowski@linux.intel.com" CC: "dri-devel@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "Vetter, Daniel" , "airlied@linux.ie" Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Explicit the connector name for DP link training result Thread-Topic: [Intel-gfx] [PATCH v2] drm/i915: Explicit the connector name for DP link training result Thread-Index: AQHS//d6y4EAv2gCJkq4oNqYO84WeQ== Date: Tue, 18 Jul 2017 18:55:52 +0000 Message-ID: <1500405356.20458.12.camel@dk-H97M-D3H> References: <20170718142536.2306-1-paul.kocialkowski@linux.intel.com> In-Reply-To: <20170718142536.2306-1-paul.kocialkowski@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.54.75.5] Content-Type: text/plain; charset="utf-8" Content-ID: <4F69E527BEBA0844BD7EC42C30A5FCBD@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v6IIu0ZB026172 Content-Length: 1836 Lines: 46 On Tue, 2017-07-18 at 17:25 +0300, Paul Kocialkowski wrote: > This adds the connector name when printing a debug message about the DP > link training result. It is useful to figure out what connector is > failing when multiple DP connectors are used. > > Signed-off-by: Paul Kocialkowski > --- > drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c > index b79c1c0e404c..05907fa8a553 100644 > --- a/drivers/gpu/drm/i915/intel_dp_link_training.c > +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c > @@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) > if (!intel_dp_link_training_channel_equalization(intel_dp)) > goto failure_handling; > > - DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d", > + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training Passed at Link Rate = %d, Lane count = %d", > + intel_connector->base.base.id, > + intel_connector->base.name, > intel_dp->link_rate, intel_dp->lane_count); > return; > > failure_handling: > - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d", > + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training failed at link rate = %d, lane count = %d", > + intel_connector->base.base.id, > + intel_connector->base.name, > intel_dp->link_rate, intel_dp->lane_count); > if (!intel_dp_get_link_train_fallback_values(intel_dp, > intel_dp->link_rate, Reviewed-by: Dhinakaran Pandiyan The choice of upper v/s lower case letters in these debug messages is a bit odd. Passed/failed Link rate/link rate Lane count/lane count