Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751530AbdGRTNr (ORCPT ); Tue, 18 Jul 2017 15:13:47 -0400 Received: from mga06.intel.com ([134.134.136.31]:21651 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751402AbdGRTNq (ORCPT ); Tue, 18 Jul 2017 15:13:46 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,378,1496127600"; d="scan'208";a="1152797819" Date: Tue, 18 Jul 2017 12:20:36 -0700 From: Manasi Navare To: Paul Kocialkowski Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Vetter , Jani Nikula , David Airlie Subject: Re: [PATCH v2] drm/i915: Explicit the connector name for DP link training result Message-ID: <20170718192036.GB6173@intel.com> References: <20170718142536.2306-1-paul.kocialkowski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170718142536.2306-1-paul.kocialkowski@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1978 Lines: 46 On Tue, Jul 18, 2017 at 05:25:36PM +0300, Paul Kocialkowski wrote: > This adds the connector name when printing a debug message about the DP > link training result. It is useful to figure out what connector is > failing when multiple DP connectors are used. > Thanks for the patch, this does make sense during the link training failure debugging to know the connector name. While at it feel free to change "Failed", "Link Rate, Lane Count", to upper case in the failure_handling case to be consistent with the pass case. Reviewed-by: Manasi Navare Manasi > Signed-off-by: Paul Kocialkowski > --- > drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c > index b79c1c0e404c..05907fa8a553 100644 > --- a/drivers/gpu/drm/i915/intel_dp_link_training.c > +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c > @@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) > if (!intel_dp_link_training_channel_equalization(intel_dp)) > goto failure_handling; > > - DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d", > + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training Passed at Link Rate = %d, Lane count = %d", > + intel_connector->base.base.id, > + intel_connector->base.name, > intel_dp->link_rate, intel_dp->lane_count); > return; > > failure_handling: > - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d", > + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training failed at link rate = %d, lane count = %d", > + intel_connector->base.base.id, > + intel_connector->base.name, > intel_dp->link_rate, intel_dp->lane_count); > if (!intel_dp_get_link_train_fallback_values(intel_dp, > intel_dp->link_rate, > -- > 2.13.2 >