Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751689AbdGRTOL (ORCPT ); Tue, 18 Jul 2017 15:14:11 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:60215 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751546AbdGRTOJ (ORCPT ); Tue, 18 Jul 2017 15:14:09 -0400 Subject: Re: [PATCH 4/4] ARM: dts: keystone-k2g-evm: Add gpio nodes To: Keerthy , , CC: , , , , , , References: <1500375436-9435-1-git-send-email-j-keerthy@ti.com> <1500375436-9435-5-git-send-email-j-keerthy@ti.com> From: Suman Anna Message-ID: <1cd6ef99-a98e-7cdb-5c2a-f5cd057eef41@ti.com> Date: Tue, 18 Jul 2017 14:13:42 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1500375436-9435-5-git-send-email-j-keerthy@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.58.153] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2667 Lines: 85 Hi Keerthy, On 07/18/2017 05:57 AM, Keerthy wrote: > keystone-k2g has 2 instances of gpio. The first one has all the 144 GPIOs Please use 66AK2G for keystone-k2g. > functional( 9 banks with 16 gpios = 144). The second instance has > only the GPIO0:GPIO67 functional and rest are marked reserved. > > Signed-off-by: Keerthy > --- > arch/arm/boot/dts/keystone-k2g.dtsi | 42 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi > index bf4d1fa..58ac3db 100644 > --- a/arch/arm/boot/dts/keystone-k2g.dtsi > +++ b/arch/arm/boot/dts/keystone-k2g.dtsi > @@ -15,6 +15,7 @@ > > #include > #include > +#include > > / { > compatible = "ti,k2g","ti,keystone"; > @@ -168,5 +169,46 @@ > #reset-cells = <2>; > }; > }; > + > + gpio0: gpio@2603000 { > + compatible = "ti,keystone-k2g-gpio"; > + reg = <0x02603000 0x100>; > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + ; > + interrupt-controller; > + #interrupt-cells = <2>; > + ti,ngpio = <144>; > + ti,davinci-gpio-unbanked = <0>; > + clocks = <&k2g_clks 0x001b 0x0>; > + clock-names = "gpio"; I don't see the clocks and clock-names documented in the binding. Looking at davinci_gpio_irq_setup(), these are required, and a specific clock name is what the driver is looking for. And you have different semantics for this on K2G and non-K2G SoCs. Davinci platforms are using non-DT clocks, so their DT nodes didn't have them. regards Suman > + }; > + > + gpio1: gpio@260a000 { > + compatible = "ti,keystone-k2g-gpio"; > + reg = <0x0260a000 0x100>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupts = , > + , > + , > + , > + ; > + interrupt-controller; > + #interrupt-cells = <2>; > + ti,ngpio = <68>; > + ti,davinci-gpio-unbanked = <0>; > + clocks = <&k2g_clks 0x001c 0x0>; > + clock-names = "gpio"; > + }; > }; > }; >