Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752077AbdGRTgd (ORCPT ); Tue, 18 Jul 2017 15:36:33 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:60139 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751844AbdGRTg3 (ORCPT ); Tue, 18 Jul 2017 15:36:29 -0400 Date: Tue, 18 Jul 2017 12:36:27 -0700 From: Matthew Wilcox To: Josef Bacik Cc: Dennis Zhou , Tejun Heo , Christoph Lameter , kernel-team@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dennis Zhou Subject: Re: [PATCH 06/10] percpu: modify base_addr to be region specific Message-ID: <20170718193627.GA18303@bombadil.infradead.org> References: <20170716022315.19892-1-dennisz@fb.com> <20170716022315.19892-7-dennisz@fb.com> <20170718192601.GB4009@destiny> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170718192601.GB4009@destiny> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 491 Lines: 12 On Tue, Jul 18, 2017 at 03:26:02PM -0400, Josef Bacik wrote: > On Sat, Jul 15, 2017 at 10:23:11PM -0400, Dennis Zhou wrote: > > + map_size_bytes = (ai->reserved_size ?: ai->dyn_size) + > > + pcpu_reserved_offset; > > This confused me for a second, better to be explicit with > > (ai->reserved_size ? 0 : ai->dyn_size) + pcpu_reserved_offset; You're still confused ;-) What Dennis wrote is equivalent to: (ai->reserved_size ? ai->reserved_size : ai->dyn_size) + pcpu_reserved_offset;