Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752225AbdGRT5s (ORCPT ); Tue, 18 Jul 2017 15:57:48 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:36172 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751997AbdGRT5r (ORCPT ); Tue, 18 Jul 2017 15:57:47 -0400 Subject: Re: [PATCH v1 00/25] lib, rtc: Print rtc_time via %pt[dt][rv] To: Joe Perches , Andy Shevchenko , Rasmus Villemoes , Greg Kroah-Hartman , Andrew Morton , linux-kernel@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org References: <20170608134811.60786-1-andriy.shevchenko@linux.intel.com> <1500400205.25934.27.camel@perches.com> From: Mark Salyzyn Message-ID: <861fe353-eb95-615f-b1dc-3326501342af@android.com> Date: Tue, 18 Jul 2017 12:57:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1500400205.25934.27.camel@perches.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1028 Lines: 34 On 07/18/2017 10:50 AM, Joe Perches wrote: > On Thu, 2017-06-08 at 16:47 +0300, Andy Shevchenko wrote: >> Recently I have noticed too many users of struct rtc_time that printing >> its content field by field. >> >> In this series I introduce %pt[dt][rv] specifier to make life a bit >> easier. > Hey Andy. > > I just saw a patch with a printk for rtc time from Mark Salyzyn. > https://lkml.org/lkml/2017/7/18/885 > > Any idea if you want to push this extension? > > I like the concept and still think it could be extended a bit more. > > from: https://lkml.org/lkml/2017/6/8/1134 > > My preference would be for %pt[type] > where is mandatory and could be: > > r for struct rtc_time > 6 for time64_t > k for ktime_t > T for struct timespec64 > etc > > and has an unspecified default of > YYYY-MM-DD:hh:mm:ss > > Perhaps use the "date" formats without the leading > % uses for for additional styles. > YYYY-MM-DD hh:mm:ss.nnnnnnnnn ?