Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752084AbdGRT6q (ORCPT ); Tue, 18 Jul 2017 15:58:46 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:60086 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751413AbdGRT6p (ORCPT ); Tue, 18 Jul 2017 15:58:45 -0400 Date: Tue, 18 Jul 2017 21:58:41 +0200 From: Andrew Lunn To: Vivien Didelot Cc: David Miller , f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com Subject: Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops Message-ID: <20170718195841.GC12449@lunn.ch> References: <20170717210405.GC11719@lunn.ch> <20170717.141048.999243831453421230.davem@davemloft.net> <20170718.104636.315406311682846961.davem@davemloft.net> <87d18xpo4f.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87d18xpo4f.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 299 Lines: 8 > I know this looks boring, I do not particularly enjoy it myself, but I > think this is also important. I don't mind fixing the poking function as > well in the near future. It would be great if you do. It could be as simple as using phy_ethtool_get_eee() and phy_ethtool_set_eee(). Andrew