Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752364AbdGRUJQ (ORCPT ); Tue, 18 Jul 2017 16:09:16 -0400 Received: from terminus.zytor.com ([65.50.211.136]:58055 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751465AbdGRUJP (ORCPT ); Tue, 18 Jul 2017 16:09:15 -0400 Date: Tue, 18 Jul 2017 13:06:56 -0700 From: tip-bot for Julia Lawall Message-ID: Cc: tglx@linutronix.de, hpa@zytor.com, Julia.Lawall@lip6.fr, mingo@kernel.org, linux-kernel@vger.kernel.org, jason@lakedaemon.net, marc.zyngier@arm.com Reply-To: linux-kernel@vger.kernel.org, jason@lakedaemon.net, marc.zyngier@arm.com, tglx@linutronix.de, hpa@zytor.com, mingo@kernel.org, Julia.Lawall@lip6.fr In-Reply-To: <1500149266-32357-6-git-send-email-Julia.Lawall@lip6.fr> References: <1500149266-32357-6-git-send-email-Julia.Lawall@lip6.fr> To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/urgent] irqchip/gic/realview: Drop unnecessary static Git-Commit-ID: 512f9e790897e84d5b802436768508ee4628fc16 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1739 Lines: 64 Commit-ID: 512f9e790897e84d5b802436768508ee4628fc16 Gitweb: http://git.kernel.org/tip/512f9e790897e84d5b802436768508ee4628fc16 Author: Julia Lawall AuthorDate: Sat, 15 Jul 2017 22:07:40 +0200 Committer: Thomas Gleixner CommitDate: Tue, 18 Jul 2017 21:59:22 +0200 irqchip/gic/realview: Drop unnecessary static Drop static on a local variable, when the variable is initialized before any possible use. Thus, the static has no benefit. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @bad exists@ position p; identifier x; type T; @@ static T x@p; ... x = <+...x...+> @@ identifier x; expression e; type T; position p != bad.p; @@ -static T x@p; ... when != x when strict ?x = e; // Signed-off-by: Julia Lawall Signed-off-by: Thomas Gleixner Cc: Marc Zyngier Cc: kernel-janitors@vger.kernel.org Cc: keescook@chromium.org Cc: Jason Cooper Link: http://lkml.kernel.org/r/1500149266-32357-6-git-send-email-Julia.Lawall@lip6.fr --- drivers/irqchip/irq-gic-realview.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-realview.c b/drivers/irqchip/irq-gic-realview.c index 54c2964..18d58d2 100644 --- a/drivers/irqchip/irq-gic-realview.c +++ b/drivers/irqchip/irq-gic-realview.c @@ -43,7 +43,7 @@ static const struct of_device_id syscon_pldset_of_match[] = { static int __init realview_gic_of_init(struct device_node *node, struct device_node *parent) { - static struct regmap *map; + struct regmap *map; struct device_node *np; const struct of_device_id *gic_id; u32 pld1_ctrl;