Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752293AbdGRUJf (ORCPT ); Tue, 18 Jul 2017 16:09:35 -0400 Received: from terminus.zytor.com ([65.50.211.136]:60659 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbdGRUJe (ORCPT ); Tue, 18 Jul 2017 16:09:34 -0400 Date: Tue, 18 Jul 2017 13:07:20 -0700 From: tip-bot for Julia Lawall Message-ID: Cc: marc.zyngier@arm.com, Julia.Lawall@lip6.fr, hpa@zytor.com, jason@lakedaemon.net, mingo@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org Reply-To: tglx@linutronix.de, linux-kernel@vger.kernel.org, jason@lakedaemon.net, mingo@kernel.org, hpa@zytor.com, Julia.Lawall@lip6.fr, marc.zyngier@arm.com In-Reply-To: <1500149266-32357-7-git-send-email-Julia.Lawall@lip6.fr> References: <1500149266-32357-7-git-send-email-Julia.Lawall@lip6.fr> To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/urgent] irqchip/mips-cpu: Drop unnecessary static Git-Commit-ID: 82faeffa7e130e2ae43aa681a34c02d56dabd177 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1721 Lines: 64 Commit-ID: 82faeffa7e130e2ae43aa681a34c02d56dabd177 Gitweb: http://git.kernel.org/tip/82faeffa7e130e2ae43aa681a34c02d56dabd177 Author: Julia Lawall AuthorDate: Sat, 15 Jul 2017 22:07:41 +0200 Committer: Thomas Gleixner CommitDate: Tue, 18 Jul 2017 21:59:22 +0200 irqchip/mips-cpu: Drop unnecessary static Drop static on a local variable, when the variable is initialized before any possible use. Thus, the static has no benefit. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @bad exists@ position p; identifier x; type T; @@ static T x@p; ... x = <+...x...+> @@ identifier x; expression e; type T; position p != bad.p; @@ -static T x@p; ... when != x when strict ?x = e; // Signed-off-by: Julia Lawall Signed-off-by: Thomas Gleixner Cc: Marc Zyngier Cc: kernel-janitors@vger.kernel.org Cc: keescook@chromium.org Cc: Jason Cooper Link: http://lkml.kernel.org/r/1500149266-32357-7-git-send-email-Julia.Lawall@lip6.fr --- drivers/irqchip/irq-mips-cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-mips-cpu.c b/drivers/irqchip/irq-mips-cpu.c index 0a8ed1c..14461cb 100644 --- a/drivers/irqchip/irq-mips-cpu.c +++ b/drivers/irqchip/irq-mips-cpu.c @@ -154,7 +154,7 @@ asmlinkage void __weak plat_irq_dispatch(void) static int mips_cpu_intc_map(struct irq_domain *d, unsigned int irq, irq_hw_number_t hw) { - static struct irq_chip *chip; + struct irq_chip *chip; if (hw < 2 && cpu_has_mipsmt) { /* Software interrupts are used for MT/CMT IPI */