Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752439AbdGRUKQ (ORCPT <rfc822;w@1wt.eu>);
        Tue, 18 Jul 2017 16:10:16 -0400
Received: from terminus.zytor.com ([65.50.211.136]:37131 "EHLO
        terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752058AbdGRUKO (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 18 Jul 2017 16:10:14 -0400
Date: Tue, 18 Jul 2017 13:07:43 -0700
From: tip-bot for Julia Lawall <tipbot@zytor.com>
Message-ID: <tip-acc80c39929b9f2ff8b45fcfe103385a3e45c1a7@git.kernel.org>
Cc: mingo@kernel.org, jason@lakedaemon.net, marc.zyngier@arm.com,
        hpa@zytor.com, Julia.Lawall@lip6.fr, tglx@linutronix.de,
        baruch@tkos.co.il, linux-kernel@vger.kernel.org
Reply-To: jason@lakedaemon.net, mingo@kernel.org, marc.zyngier@arm.com,
        tglx@linutronix.de, Julia.Lawall@lip6.fr, hpa@zytor.com,
        linux-kernel@vger.kernel.org, baruch@tkos.co.il
In-Reply-To: <1500149266-32357-11-git-send-email-Julia.Lawall@lip6.fr>
References: <1500149266-32357-11-git-send-email-Julia.Lawall@lip6.fr>
To: linux-tip-commits@vger.kernel.org
Subject: [tip:irq/urgent] irqchip/digicolor: Drop unnecessary static
Git-Commit-ID: acc80c39929b9f2ff8b45fcfe103385a3e45c1a7
X-Mailer: tip-git-log-daemon
Robot-ID: <tip-bot.git.kernel.org>
Robot-Unsubscribe: Contact <mailto:hpa@kernel.org> to get blacklisted from
 these emails
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=UTF-8
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1853
Lines: 66

Commit-ID:  acc80c39929b9f2ff8b45fcfe103385a3e45c1a7
Gitweb:     http://git.kernel.org/tip/acc80c39929b9f2ff8b45fcfe103385a3e45c1a7
Author:     Julia Lawall <Julia.Lawall@lip6.fr>
AuthorDate: Sat, 15 Jul 2017 22:07:45 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 18 Jul 2017 21:59:23 +0200

irqchip/digicolor: Drop unnecessary static

Drop static on a local variable, when the variable is initialized before
any possible use.  Thus, the static has no benefit.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@bad exists@
position p;
identifier x;
type T;
@@
static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@
-static
 T x@p;
 ... when != x
     when strict
?x = e;
// </smpl>


Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Cc: keescook@chromium.org
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: kernel-janitors@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: Jason Cooper <jason@lakedaemon.net>
Link: http://lkml.kernel.org/r/1500149266-32357-11-git-send-email-Julia.Lawall@lip6.fr

---
 drivers/irqchip/irq-digicolor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-digicolor.c b/drivers/irqchip/irq-digicolor.c
index dad85e7..3aae015 100644
--- a/drivers/irqchip/irq-digicolor.c
+++ b/drivers/irqchip/irq-digicolor.c
@@ -71,7 +71,7 @@ static void __init digicolor_set_gc(void __iomem *reg_base, unsigned irq_base,
 static int __init digicolor_of_init(struct device_node *node,
 				struct device_node *parent)
 {
-	static void __iomem *reg_base;
+	void __iomem *reg_base;
 	unsigned int clr = IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN;
 	struct regmap *ucregs;
 	int ret;