Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752656AbdGRWFR (ORCPT ); Tue, 18 Jul 2017 18:05:17 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:54700 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752070AbdGRWFP (ORCPT ); Tue, 18 Jul 2017 18:05:15 -0400 Date: Wed, 19 Jul 2017 00:05:13 +0200 From: Ralf Baechle To: Harvey Hunt Cc: John Crispin , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] MIPS: ralink: mt7620: Add missing header Message-ID: <20170718220513.GB22091@linux-mips.org> References: <1500384346-10527-1-git-send-email-harvey.hunt@imgtec.com> <1500384346-10527-2-git-send-email-harvey.hunt@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1500384346-10527-2-git-send-email-harvey.hunt@imgtec.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1355 Lines: 30 On Tue, Jul 18, 2017 at 02:25:46PM +0100, Harvey Hunt wrote: > Fix a build error caused by not including . > > The following compilation errors are caused by the missing header: > > arch/mips/ralink/mt7620.c: In function ‘mt7620_get_cpu_pll_rate’: > arch/mips/ralink/mt7620.c:431:2: error: implicit declaration of function ‘WARN_ON’ [-Werror=implicit-function-declaration] > WARN_ON(div >= ARRAY_SIZE(mt7620_clk_divider)); > ^ > arch/mips/ralink/mt7620.c: In function ‘mt7620_get_sys_rate’: > arch/mips/ralink/mt7620.c:500:2: error: implicit declaration of function ‘WARN’ [-Werror=implicit-function-declaration] > if (WARN(!div, "invalid divider for OCP ratio %u", ocp_ratio)) > ^ > arch/mips/ralink/mt7620.c: In function ‘mt7620_dram_init’: > arch/mips/ralink/mt7620.c:619:3: error: implicit declaration of function ‘BUG’ [-Werror=implicit-function-declaration] > BUG(); > ^ > cc1: some warnings being treated as errors > scripts/Makefile.build:302: recipe for target 'arch/mips/ralink/mt7620.o' failed > > Signed-off-by: Harvey Hunt > Cc: John Crispin > Cc: linux-mips@linux-mips.org > Cc: linux-kernel@vger.kernel.org Same comment as for the previous patch - looks sensible, so applied. But I'm wondering why I don't see this in test builds. Ralf