Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752442AbdGRWwK (ORCPT ); Tue, 18 Jul 2017 18:52:10 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:48936 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751647AbdGRWwJ (ORCPT ); Tue, 18 Jul 2017 18:52:09 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 69AEB60AD7 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Tue, 18 Jul 2017 15:52:03 -0700 From: Stephen Boyd To: Vladimir Zapolskiy Cc: gabriel.fernandez@st.com, Rob Herring , Mark Rutland , Russell King , Maxime Coquelin , Alexandre Torgue , Michael Turquette , Nicolas Pitre , Arnd Bergmann , daniel.thompson@linaro.org, andrea.merello@gmail.com, radoslaw.pietrzyk@gmail.com, Lee Jones , Sylvain Lemieux , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, ludovic.barre@st.com, olivier.bideau@st.com, amelie.delaunay@st.com, gabriel.fernandez.st@gmail.com, Arvind Yadav Subject: Re: [PATCH v6 2/3] clk: gate: expose clk_gate_ops::is_enabled Message-ID: <20170718225203.GD18179@codeaurora.org> References: <1500364414-10021-1-git-send-email-gabriel.fernandez@st.com> <1500364414-10021-3-git-send-email-gabriel.fernandez@st.com> <55bc0f3f-67ed-a15f-5b71-d87044fd5237@mleia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55bc0f3f-67ed-a15f-5b71-d87044fd5237@mleia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1395 Lines: 32 On 07/18, Vladimir Zapolskiy wrote: > On 07/18/2017 10:53 AM, gabriel.fernandez@st.com wrote: > > From: Gabriel Fernandez > > } > > +EXPORT_SYMBOL_GPL(clk_gate_is_enabled); > > > > const struct clk_ops clk_gate_ops = { > > .enable = clk_gate_enable, > > diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h > > index c59c625..e9587ab 100644 > > --- a/include/linux/clk-provider.h > > +++ b/include/linux/clk-provider.h > > @@ -343,6 +343,7 @@ struct clk_hw *clk_hw_register_gate(struct device *dev, const char *name, > > u8 clk_gate_flags, spinlock_t *lock); > > void clk_unregister_gate(struct clk *clk); > > void clk_hw_unregister_gate(struct clk_hw *hw); > > +int clk_gate_is_enabled(struct clk_hw *hw); > > Here the prefix does not reflect the type of its argument, it might be > acceptable for a veiled function, but it is not wanted for the exported > function. Something like clk_hw_gate_is_enabled() is expected here, but > again, let's firstly come to an agreement, that the export is needed. > I'd prefer clk_gate_is_enabled() as it's not a struct clk_hw_gate, it's a struct clk_gate and there isn't any requirement for function names to reflect the type of the argument. That's what we have type analysis for. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project