Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752429AbdGRXvr (ORCPT ); Tue, 18 Jul 2017 19:51:47 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:51567 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbdGRXvp (ORCPT ); Tue, 18 Jul 2017 19:51:45 -0400 Subject: Re: [PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support TI-SCI protocol To: "Andrew F. Davis" , Santosh Shilimkar CC: Rob Herring , Franklin S Cooper Jr , , , , Nishanth Menon , Tero Kristo , Dave Gerlach References: <20170718032844.29490-1-s-anna@ti.com> <20170718032844.29490-2-s-anna@ti.com> <8b8c4eff-4f18-f0d2-e075-389921e5a990@ti.com> From: Suman Anna Message-ID: <4ff798de-9926-4bf8-74a5-572f0f0c1081@ti.com> Date: Tue, 18 Jul 2017 18:50:44 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <8b8c4eff-4f18-f0d2-e075-389921e5a990@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.58.153] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1772 Lines: 56 On 07/18/2017 10:00 AM, Andrew F. Davis wrote: > On 07/17/2017 10:28 PM, Suman Anna wrote: >> From: Nishanth Menon >> >> Texas Instrument's System Control Interface (TI-SCI) Message Protocol >> is implemented in Keystone 2 generation 66AK2G SoC with the PMMC entity. >> >> Add the ti-sci node representing this 66AK2G PMMC module. >> >> Signed-off-by: Nishanth Menon >> [s-anna@ti.com: add unit address to DT node] >> Signed-off-by: Suman Anna >> --- >> arch/arm/boot/dts/keystone-k2g.dtsi | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi >> index a789f75a1ed5..7f0f4180b373 100644 >> --- a/arch/arm/boot/dts/keystone-k2g.dtsi >> +++ b/arch/arm/boot/dts/keystone-k2g.dtsi >> @@ -139,5 +139,19 @@ >> interrupts = , >> ; >> }; >> + >> + pmmc: pmmc@02921c00 { >> + compatible = "ti,k2g-sci"; >> + /* >> + * In case of rare platforms that does not use k2g as >> + * system master, use /delete-property/ >> + */ > > This comment seems mis-worded, I believe this was meant to say "for > platforms that do not use the *PMMC* as the system master". The comment is for the system-reboot-controller property, and is meant to say that this property is to be deleted from this node if there is an external entity on the board other than the K2G SoC that is responsible for triggering a reboot. regards Suman > > Andrew > >> + ti,system-reboot-controller; >> + mbox-names = "rx", "tx"; >> + mboxes= <&msgmgr 5 2>, >> + <&msgmgr 0 0>; >> + reg-names = "debug_messages"; >> + reg = <0x02921c00 0x400>; >> + }; >> }; >> }; >>