Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752459AbdGSAQM (ORCPT ); Tue, 18 Jul 2017 20:16:12 -0400 Received: from mga03.intel.com ([134.134.136.65]:53483 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbdGSAQK (ORCPT ); Tue, 18 Jul 2017 20:16:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,378,1496127600"; d="scan'208";a="994512469" From: "Zhang, Tina" To: Gerd Hoffmann , Kirti Wankhede , "Tian, Kevin" , "linux-kernel@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "alex.williamson@redhat.com" , "zhenyuw@linux.intel.com" , "chris@chris-wilson.co.uk" , "Lv, Zhiyuan" , "intel-gvt-dev@lists.freedesktop.org" , "Wang, Zhi A" Subject: RE: [PATCH v10] vfio: ABI for mdev display dma-buf operation Thread-Topic: [PATCH v10] vfio: ABI for mdev display dma-buf operation Thread-Index: AQHS9d72/JOqiz5kqkOIoMWmOT5rIKJGTuYAgAdZDwCAADHdAIABpeDA///SwgCAAFUVgIAC7DhggAAN1wCAAB+RgIAAAtOAgASiyYCAAvNP0A== Date: Wed, 19 Jul 2017 00:16:04 +0000 Message-ID: <237F54289DF84E4997F34151298ABEBC7C58235A@SHSMSX101.ccr.corp.intel.com> References: <1499293795-6265-1-git-send-email-tina.zhang@intel.com> <980a5c09-fa8a-255d-19ad-acf4bb29d271@nvidia.com> <1499753648.8257.3.camel@redhat.com> <20170711091236.run4zirxmr34kazb@phenom.ffwll.local> <237F54289DF84E4997F34151298ABEBC7C57BF86@SHSMSX101.ccr.corp.intel.com> <20170712074038.izr6ureby4vwtq27@phenom.ffwll.local> <237F54289DF84E4997F34151298ABEBC7C57E3FF@SHSMSX101.ccr.corp.intel.com> <2c07d8ee-d974-33ec-2cf4-b320fc466c88@nvidia.com> <1500033939.28252.16.camel@redhat.com> <100da721-b765-ed65-7b4b-86e737e2889d@nvidia.com> <1500289405.12570.5.camel@redhat.com> In-Reply-To: <1500289405.12570.5.camel@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v6J0GF9S012401 Content-Length: 1264 Lines: 35 > -----Original Message----- > From: Gerd Hoffmann [mailto:kraxel@redhat.com] > Sent: Monday, July 17, 2017 7:03 PM > To: Kirti Wankhede ; Zhang, Tina > ; Tian, Kevin ; linux- > kernel@vger.kernel.org; intel-gfx@lists.freedesktop.org; > alex.williamson@redhat.com; zhenyuw@linux.intel.com; chris@chris- > wilson.co.uk; Lv, Zhiyuan ; intel-gvt- > dev@lists.freedesktop.org; Wang, Zhi A > Subject: Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation > > Hi, > > > No need of flag here. If vGPU driver is not loaded in the guest, there > > is no surface being managed by vGPU, in that case this size will be > > zero. > > Ok, we certainly have the same situation with intel. When the guest driver is not > loaded (yet) there is no valid surface. > > We should cleanly define what the ioctl should do in that case, so all drivers > behave the same way. > > I'd suggest that all fields defining the surface (drm_format, width, height, stride, > size) should be set to zero in that case. Yeah, it's reasonable. How about the return value? Currently, the ioctl also returns "-ENODEV" in that situation. thanks, Tina > > cheers, > Gerd